GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-08-12 19:59:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

bug fix in novel makeGivens for real

Browse Source
This commit is contained in:
Gael Guennebaud 2009-09-04 10:05:22 +02:00
parent 3fbf71d6b9
commit a7ed998d52
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Eigen/src/Jacobi/Jacobi.h
View File

@ -233,7 +233,7 @@ void PlanarRotation<Scalar>::makeGivens(const Scalar& p, const Scalar& q, Scalar
m_s = q<Scalar(0) ? Scalar(1) : Scalar(-1); m_s = q<Scalar(0) ? Scalar(1) : Scalar(-1);
if(r) *r = ei_abs(q); if(r) *r = ei_abs(q);
} }
else if(p>q) else if(ei_abs(p) > ei_abs(q))
{ {
Scalar t = q/p; Scalar t = q/p;
Scalar u = ei_sqrt(Scalar(1) + ei_abs2(t)); Scalar u = ei_sqrt(Scalar(1) + ei_abs2(t));
@ -250,7 +250,7 @@ void PlanarRotation<Scalar>::makeGivens(const Scalar& p, const Scalar& q, Scalar
if(q<Scalar(0)) if(q<Scalar(0))
u = -u; u = -u;
m_s = -Scalar(1)/u; m_s = -Scalar(1)/u;
m_c = t * m_s; m_c = -t * m_s;
if(r) *r = q * u; if(r) *r = q * u;
} }