Update comment as suggested by tra@google.com.

This commit is contained in:
Rasmus Munk Larsen 2019-06-20 16:18:37 -07:00
parent e5e63c2cad
commit b8f8dac4eb
2 changed files with 6 additions and 6 deletions

View File

@ -313,9 +313,9 @@ EIGEN_STRONG_INLINE __device__ bool operator >= (const half& a, const half& b) {
#endif #endif
// The EIGEN_COMP_CLANG && !EIGEN_COMP_NVCC clause is necessary on Mac where we // We need to distinguish clang as the CUDA compiler from clang as the host compiler,
// suspect that NVCC is doing device-side preprocessing with clang, but actually // invoked by NVCC (e.g. on MacOS). The former needs to see both host and device implementation
// compiling with cicc, which is obviously not clang. // of the functions, while the latter can only deal with one one of them.
#if !defined(EIGEN_HAS_NATIVE_FP16) || (EIGEN_COMP_CLANG && !EIGEN_COMP_NVCC) // Emulate support for half floats #if !defined(EIGEN_HAS_NATIVE_FP16) || (EIGEN_COMP_CLANG && !EIGEN_COMP_NVCC) // Emulate support for half floats
#if EIGEN_COMP_CLANG && defined(EIGEN_CUDACC) #if EIGEN_COMP_CLANG && defined(EIGEN_CUDACC)

View File

@ -102,9 +102,9 @@ template<> EIGEN_DEVICE_FUNC EIGEN_STRONG_INLINE double2 pset1<double2>(const do
return make_double2(from, from); return make_double2(from, from);
} }
// The EIGEN_COMP_CLANG && !EIGEN_COMP_NVCC clause is necessary on Mac where we // We need to distinguish clang as the CUDA compiler from clang as the host compiler,
// suspect that NVCC is doing device-side preprocessing with clang, but actually // invoked by NVCC (e.g. on MacOS). The former needs to see both host and device implementation
// compiling with cicc, which is obviously not clang. // of the functions, while the latter can only deal with one one of them.
#if defined(EIGEN_CUDA_ARCH) || defined(EIGEN_HIP_DEVICE_COMPILE) || (defined(EIGEN_CUDACC) && EIGEN_COMP_CLANG && !EIGEN_COMP_NVCC) #if defined(EIGEN_CUDA_ARCH) || defined(EIGEN_HIP_DEVICE_COMPILE) || (defined(EIGEN_CUDACC) && EIGEN_COMP_CLANG && !EIGEN_COMP_NVCC)
namespace { namespace {