GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-09-13 01:43:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Let's properly use Score instead of std::abs, and remove deprecated FIXME ( a /= b does a/b and not a * (1/b) as it was a long time ago...)

Browse Source
This commit is contained in:
Gael Guennebaud 2019-02-11 22:56:19 +01:00
parent 2edfc6807d
commit bdcb5f3304
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Eigen/src/LU/PartialPivLU.h
View File

@ -387,8 +387,6 @@ struct partial_lu_impl
++nb_transpositions; ++nb_transpositions;
} }
// FIXME shall we introduce a safe quotient expression in cas 1/lu.coeff(k,k)
// overflow but not the actual quotient?
lu.col(k).tail(fix<RRows>(rrows)) /= lu.coeff(k,k); lu.col(k).tail(fix<RRows>(rrows)) /= lu.coeff(k,k);
} }
else if(first_zero_pivot==-1) else if(first_zero_pivot==-1)
@ -407,7 +405,7 @@ struct partial_lu_impl
{ {
Index k = endk; Index k = endk;
row_transpositions[k] = PivIndex(k); row_transpositions[k] = PivIndex(k);
if (std::abs(lu(k, k)) == 0 && first_zero_pivot == -1) if (Scoring()(lu(k, k)) == Score(0) && first_zero_pivot == -1)
first_zero_pivot = k; first_zero_pivot = k;
} }