GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-08-12 03:39:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix warnings. The one in Reverse was potentially serious: coeff() methods should return CoeffReturnType, not "Scalar", if the expression is potentially a Lvalue.

Browse Source
This commit is contained in:
Benoit Jacob 2010-08-03 10:38:48 -04:00
parent cc25edd5de
commit d90d7a006f
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Eigen/src/Core/Reverse.h
View File

@ -126,13 +126,13 @@ template<typename MatrixType, int Direction> class Reverse
ReverseCol ? m_matrix.cols() - col - 1 : col); ReverseCol ? m_matrix.cols() - col - 1 : col);
} }
inline const Scalar coeff(Index row, Index col) const inline CoeffReturnType coeff(Index row, Index col) const
{ {
return m_matrix.coeff(ReverseRow ? m_matrix.rows() - row - 1 : row, return m_matrix.coeff(ReverseRow ? m_matrix.rows() - row - 1 : row,
ReverseCol ? m_matrix.cols() - col - 1 : col); ReverseCol ? m_matrix.cols() - col - 1 : col);
} }
inline const Scalar coeff(Index index) const inline CoeffReturnType coeff(Index index) const
{ {
return m_matrix.coeff(m_matrix.size() - index - 1); return m_matrix.coeff(m_matrix.size() - index - 1);
} }

7
Eigen/src/Core/products/GeneralMatrixVector.h
View File

@ -63,8 +63,11 @@ EIGEN_DONT_INLINE static void run(
Index rows, Index cols, Index rows, Index cols,
const LhsScalar* lhs, Index lhsStride, const LhsScalar* lhs, Index lhsStride,
const RhsScalar* rhs, Index rhsIncr, const RhsScalar* rhs, Index rhsIncr,
ResScalar* res, Index resIncr, ResScalar* res, Index
RhsScalar alpha) #ifdef EIGEN_INTERNAL_DEBUGGING
resIncr
#endif
, RhsScalar alpha)
{ {
ei_internal_assert(resIncr==1); ei_internal_assert(resIncr==1);
#ifdef _EIGEN_ACCUMULATE_PACKETS #ifdef _EIGEN_ACCUMULATE_PACKETS