GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-04-20 16:49:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix ubsan failure in array_for_matrix

Browse Source
This commit is contained in:
Antonio Sánchez 2024-05-16 18:47:36 +00:00
parent 5e4f3475b5
commit de8013fa67
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/array_for_matrix.cpp
View File

@ -26,7 +26,7 @@ void array_for_matrix(const MatrixType& m) {
// Prevent overflows for integer types. // Prevent overflows for integer types.
if (Eigen::NumTraits<Scalar>::IsInteger) { if (Eigen::NumTraits<Scalar>::IsInteger) {
Scalar kMaxVal = Scalar(10000); Scalar kMaxVal = Scalar(1000);
m1.array() = m1.array() - kMaxVal * (m1.array() / kMaxVal); m1.array() = m1.array() - kMaxVal * (m1.array() / kMaxVal);
m2.array() = m2.array() - kMaxVal * (m2.array() / kMaxVal); m2.array() = m2.array() - kMaxVal * (m2.array() / kMaxVal);
} }
@ -123,7 +123,7 @@ void comparisons(const MatrixType& m) {
// test Select // test Select
VERIFY_IS_APPROX((m1.array() < m2.array()).select(m1, m2), m1.cwiseMin(m2)); VERIFY_IS_APPROX((m1.array() < m2.array()).select(m1, m2), m1.cwiseMin(m2));
VERIFY_IS_APPROX((m1.array() > m2.array()).select(m1, m2), m1.cwiseMax(m2)); VERIFY_IS_APPROX((m1.array() > m2.array()).select(m1, m2), m1.cwiseMax(m2));
Scalar mid = (m1.cwiseAbs().minCoeff() + m1.cwiseAbs().maxCoeff()) / Scalar(2); Scalar mid = m1.cwiseAbs().minCoeff() / Scalar(2) + m1.cwiseAbs().maxCoeff() / Scalar(2);
for (int j = 0; j < cols; ++j) for (int j = 0; j < cols; ++j)
for (int i = 0; i < rows; ++i) m3(i, j) = abs(m1(i, j)) < mid ? 0 : m1(i, j); for (int i = 0; i < rows; ++i) m3(i, j) = abs(m1(i, j)) < mid ? 0 : m1(i, j);
VERIFY_IS_APPROX( VERIFY_IS_APPROX(
@ -140,8 +140,7 @@ void comparisons(const MatrixType& m) {
// and/or // and/or
VERIFY(((m1.array() < RealScalar(0)).matrix() && (m1.array() > RealScalar(0)).matrix()).count() == 0); VERIFY(((m1.array() < RealScalar(0)).matrix() && (m1.array() > RealScalar(0)).matrix()).count() == 0);
VERIFY(((m1.array() < RealScalar(0)).matrix() || (m1.array() >= RealScalar(0)).matrix()).count() == rows * cols); VERIFY(((m1.array() < RealScalar(0)).matrix() || (m1.array() >= RealScalar(0)).matrix()).count() == rows * cols);
RealScalar a = m1.cwiseAbs().mean(); VERIFY(((m1.array() < -mid).matrix() || (m1.array() > mid).matrix()).count() == (m1.cwiseAbs().array() > mid).count());
VERIFY(((m1.array() < -a).matrix() || (m1.array() > a).matrix()).count() == (m1.cwiseAbs().array() > a).count());
typedef Matrix<Index, Dynamic, 1> VectorOfIndices; typedef Matrix<Index, Dynamic, 1> VectorOfIndices;