From fe48c25682fd8dcbcdf8fd19db64e69d6154b510 Mon Sep 17 00:00:00 2001 From: Gael Guennebaud Date: Tue, 6 Dec 2016 15:04:50 +0100 Subject: [PATCH] Revert vec/y to vec*(1/y) in row-major TRSM: - div is extremely costly - this is consistent with the column-major case - this is consistent with all other BLAS implementations (grafted from eb621413c154b79e0acab3fa0c617964aef11d34 ) --- Eigen/src/Core/products/TriangularSolverMatrix.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Eigen/src/Core/products/TriangularSolverMatrix.h b/Eigen/src/Core/products/TriangularSolverMatrix.h index 1bed66ed8..223c38b86 100644 --- a/Eigen/src/Core/products/TriangularSolverMatrix.h +++ b/Eigen/src/Core/products/TriangularSolverMatrix.h @@ -183,7 +183,7 @@ EIGEN_DONT_INLINE void triangular_solve_matrix struct triangular_solve_matrix @@ -202,6 +202,7 @@ EIGEN_DONT_INLINE void triangular_solve_matrix& blocking) { Index rows = otherSize; + typedef typename NumTraits::Real RealScalar; typedef blas_data_mapper LhsMapper; typedef const_blas_data_mapper RhsMapper; @@ -306,9 +307,9 @@ EIGEN_DONT_INLINE void triangular_solve_matrix