GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-04-30 15:54:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix underflow in JacoviSVD's complex to real preconditioner

Browse Source
This commit is contained in:
Gael Guennebaud 2016-04-13 22:49:51 +02:00
parent f4e12272f1
commit feef39e2d1
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Eigen/src/SVD/JacobiSVD.h
View File

@ -368,9 +368,15 @@ struct svd_precondition_2x2_block_to_be_real<MatrixType, QRPreconditioner, true>
if(n==0) if(n==0)
{ {
z = abs(work_matrix.coeff(p,q)) / work_matrix.coeff(p,q); // make sure firt column is zero (deflation)
work_matrix.row(p) *= z; work_matrix.coeffRef(p,p) = work_matrix.coeffRef(q,p) = Scalar(0);
if(svd.computeU()) svd.m_matrixU.col(p) *= conj(z); if(work_matrix.coeff(p,q)!=Scalar(0))
{
// work_matrix.coeff(p,q) can be zero if work_matrix.coeff(q,p) is not zero but small enough to underflow when computing n
z = abs(work_matrix.coeff(p,q)) / work_matrix.coeff(p,q);
work_matrix.row(p) *= z;
if(svd.computeU()) svd.m_matrixU.col(p) *= conj(z);
}
if(work_matrix.coeff(q,q)!=Scalar(0)) if(work_matrix.coeff(q,q)!=Scalar(0))
{ {
z = abs(work_matrix.coeff(q,q)) / work_matrix.coeff(q,q); z = abs(work_matrix.coeff(q,q)) / work_matrix.coeff(q,q);