GitHub-Proxy/filesystem
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/gulrak/filesystem synced 2025-06-04 11:13:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #34 from jeanguyomarch/toctou-race

Browse Source 
fix: TOCTOU race when creating directories
This commit is contained in:
gulrak 2019-11-06 19:54:09 +01:00 committed by GitHub
commit 741eaca3fd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
include/ghc/filesystem.hpp
View File

@ -3391,9 +3391,14 @@ GHC_INLINE bool create_directories(const path& p, std::error_code& ec) noexcept
if (!exists(fs)) { if (!exists(fs)) {
create_directory(current, ec); create_directory(current, ec);
if (ec) { if (ec) {
std::error_code tmp_ec;
if (is_directory(current, tmp_ec)) {
ec.clear();
} else {
return false; return false;
} }
} }
}
#ifndef LWG_2935_BEHAVIOUR #ifndef LWG_2935_BEHAVIOUR
else if (!is_directory(fs)) { else if (!is_directory(fs)) {
ec = detail::make_error_code(detail::portable_error::exists); ec = detail::make_error_code(detail::portable_error::exists);