From 5c0ef1cb84b589b8dbd986dfa5ffcdaeafc00358 Mon Sep 17 00:00:00 2001 From: Jun Jie Date: Thu, 2 Jul 2020 13:33:56 +0800 Subject: [PATCH] Fix test failing when simple regex is used Test MatcherDeathTest.DoesNotBreakBareRegexMatching fails when googletest uses simple regex instead of posix regex. This partially fixes #2687 --- googletest/test/googletest-death-test-test.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/googletest/test/googletest-death-test-test.cc b/googletest/test/googletest-death-test-test.cc index b0dda27fa..1bb5bb71d 100644 --- a/googletest/test/googletest-death-test-test.cc +++ b/googletest/test/googletest-death-test-test.cc @@ -1376,7 +1376,11 @@ void DieWithMessage(const char* message) { TEST(MatcherDeathTest, DoesNotBreakBareRegexMatching) { // googletest tests this, of course; here we ensure that including googlemock // has not broken it. +#if GTEST_USES_POSIX_RE EXPECT_DEATH(DieWithMessage("O, I die, Horatio."), "I d[aeiou]e"); +#else + EXPECT_DEATH(DieWithMessage("O, I die, Horatio."), "I di?e"); +#endif } TEST(MatcherDeathTest, MonomorphicMatcherMatches) {