From 02d8fdb2121ec1f239f4b05a6c45103e2ae24253 Mon Sep 17 00:00:00 2001 From: Nityananda Gohain Date: Thu, 5 Dec 2024 09:30:39 +0530 Subject: [PATCH] fix: enable smart trace detail (#6596) --- ee/query-service/app/api/traces.go | 41 +++++++++++++++--------------- 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/ee/query-service/app/api/traces.go b/ee/query-service/app/api/traces.go index 5c65089cd0..3864fc672e 100644 --- a/ee/query-service/app/api/traces.go +++ b/ee/query-service/app/api/traces.go @@ -2,31 +2,32 @@ package api import ( "net/http" + + "go.signoz.io/signoz/ee/query-service/app/db" + "go.signoz.io/signoz/ee/query-service/model" + baseapp "go.signoz.io/signoz/pkg/query-service/app" + basemodel "go.signoz.io/signoz/pkg/query-service/model" + "go.uber.org/zap" ) func (ah *APIHandler) searchTraces(w http.ResponseWriter, r *http.Request) { - ah.APIHandler.SearchTraces(w, r) - return + if !ah.CheckFeature(basemodel.SmartTraceDetail) { + zap.L().Info("SmartTraceDetail feature is not enabled in this plan") + ah.APIHandler.SearchTraces(w, r) + return + } + searchTracesParams, err := baseapp.ParseSearchTracesParams(r) + if err != nil { + RespondError(w, &model.ApiError{Typ: model.ErrorBadData, Err: err}, "Error reading params") + return + } - // This is commented since this will be taken care by new trace API + result, err := ah.opts.DataConnector.SearchTraces(r.Context(), searchTracesParams, db.SmartTraceAlgorithm) + if ah.HandleError(w, err, http.StatusBadRequest) { + return + } - // if !ah.CheckFeature(basemodel.SmartTraceDetail) { - // zap.L().Info("SmartTraceDetail feature is not enabled in this plan") - // ah.APIHandler.SearchTraces(w, r) - // return - // } - // searchTracesParams, err := baseapp.ParseSearchTracesParams(r) - // if err != nil { - // RespondError(w, &model.ApiError{Typ: model.ErrorBadData, Err: err}, "Error reading params") - // return - // } - - // result, err := ah.opts.DataConnector.SearchTraces(r.Context(), searchTracesParams, db.SmartTraceAlgorithm) - // if ah.HandleError(w, err, http.StatusBadRequest) { - // return - // } - - // ah.WriteJSON(w, r, result) + ah.WriteJSON(w, r, result) }