GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-12 10:49:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: add start/end millis for trace details response (#5321)

Browse Source
This commit is contained in:
Srikanth Chekuri 2024-06-24 14:45:26 +05:30 committed by GitHub
parent a7a160df76
commit 0375fc47a7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/query-service/app/clickhouseReader/reader.go
View File

@ -1924,6 +1924,7 @@ func (r *ClickHouseReader) SearchTraces(ctx context.Context, params *model.Searc
telemetry.GetInstance().SendEvent(telemetry.TELEMETRY_EVENT_TRACE_DETAIL_API, data, userEmail, true, false) telemetry.GetInstance().SendEvent(telemetry.TELEMETRY_EVENT_TRACE_DETAIL_API, data, userEmail, true, false)
} }
var startTime, endTime, durationNano uint64
var searchScanResponses []model.SearchSpanDBResponseItem var searchScanResponses []model.SearchSpanDBResponseItem
query := fmt.Sprintf("SELECT timestamp, traceID, model FROM %s.%s WHERE traceID=$1", r.TraceDB, r.SpansTable) query := fmt.Sprintf("SELECT timestamp, traceID, model FROM %s.%s WHERE traceID=$1", r.TraceDB, r.SpansTable)
@ -1954,6 +1955,15 @@ func (r *ClickHouseReader) SearchTraces(ctx context.Context, params *model.Searc
easyjson.Unmarshal([]byte(item.Model), &jsonItem) easyjson.Unmarshal([]byte(item.Model), &jsonItem)
jsonItem.TimeUnixNano = uint64(item.Timestamp.UnixNano() / 1000000) jsonItem.TimeUnixNano = uint64(item.Timestamp.UnixNano() / 1000000)
searchSpanResponses = append(searchSpanResponses, jsonItem) searchSpanResponses = append(searchSpanResponses, jsonItem)
if startTime == 0 || jsonItem.TimeUnixNano < startTime {
startTime = jsonItem.TimeUnixNano
}
if endTime == 0 || jsonItem.TimeUnixNano > endTime {
endTime = jsonItem.TimeUnixNano
}
if durationNano == 0 || uint64(jsonItem.DurationNano) > durationNano {
durationNano = uint64(jsonItem.DurationNano)
}
} }
end = time.Now() end = time.Now()
zap.L().Debug("getTraceSQLQuery unmarshal took: ", zap.Duration("duration", end.Sub(start))) zap.L().Debug("getTraceSQLQuery unmarshal took: ", zap.Duration("duration", end.Sub(start)))
@ -1983,6 +1993,9 @@ func (r *ClickHouseReader) SearchTraces(ctx context.Context, params *model.Searc
} }
} }
searchSpansResult[0].StartTimestampMillis = startTime - durationNano
searchSpansResult[0].EndTimestampMillis = endTime + durationNano
return &searchSpansResult, nil return &searchSpansResult, nil
} }

2
pkg/query-service/model/response.go
View File

@ -212,6 +212,8 @@ type ServiceOverviewItem struct {
} }
type SearchSpansResult struct { type SearchSpansResult struct {
StartTimestampMillis uint64 `json:"startTimestampMillis"`
EndTimestampMillis uint64 `json:"endTimestampMillis"`
Columns []string `json:"columns"` Columns []string `json:"columns"`
Events [][]interface{} `json:"events"` Events [][]interface{} `json:"events"`
IsSubTree bool `json:"isSubTree"` IsSubTree bool `json:"isSubTree"`