mirror of
https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz
synced 2025-07-14 01:21:48 +08:00
fix: exists/nexists support for top level columns (#5990)
This commit is contained in:
parent
72cbc1a9e7
commit
0711c8855e
@ -80,9 +80,23 @@ func getSelectLabels(aggregatorOperator v3.AggregateOperator, groupBy []v3.Attri
|
|||||||
|
|
||||||
func getExistsNexistsFilter(op v3.FilterOperator, item v3.FilterItem) string {
|
func getExistsNexistsFilter(op v3.FilterOperator, item v3.FilterItem) string {
|
||||||
if _, ok := constants.StaticFieldsLogsV3[item.Key.Key]; ok && item.Key.Type == v3.AttributeKeyTypeUnspecified {
|
if _, ok := constants.StaticFieldsLogsV3[item.Key.Key]; ok && item.Key.Type == v3.AttributeKeyTypeUnspecified {
|
||||||
// no exists filter for static fields as they exists everywhere
|
// https://opentelemetry.io/docs/specs/otel/logs/data-model/
|
||||||
// TODO(nitya): Think what we can do here
|
// for top level keys of the log model: trace_id, span_id, severity_number, trace_flags etc
|
||||||
return ""
|
// we don't have an exists column.
|
||||||
|
// to check if they exists/nexists
|
||||||
|
// we can use = 0 or != 0 for numbers
|
||||||
|
// we can use = '' or != '' for strings
|
||||||
|
chOp := "!="
|
||||||
|
if op == v3.FilterOperatorNotExists {
|
||||||
|
chOp = "="
|
||||||
|
}
|
||||||
|
key := getClickhouseKey(item.Key)
|
||||||
|
if item.Key.DataType == v3.AttributeKeyDataTypeString {
|
||||||
|
return fmt.Sprintf("%s %s ''", key, chOp)
|
||||||
|
}
|
||||||
|
// we just have two types, number and string for top level columns
|
||||||
|
|
||||||
|
return fmt.Sprintf("%s %s 0", key, chOp)
|
||||||
} else if item.Key.IsColumn {
|
} else if item.Key.IsColumn {
|
||||||
// get filter for materialized columns
|
// get filter for materialized columns
|
||||||
val := true
|
val := true
|
||||||
|
@ -147,7 +147,15 @@ func Test_getExistsNexistsFilter(t *testing.T) {
|
|||||||
op: v3.FilterOperatorExists,
|
op: v3.FilterOperatorExists,
|
||||||
item: v3.FilterItem{Key: v3.AttributeKey{Key: "trace_id", DataType: v3.AttributeKeyDataTypeString, Type: v3.AttributeKeyTypeUnspecified}},
|
item: v3.FilterItem{Key: v3.AttributeKey{Key: "trace_id", DataType: v3.AttributeKeyDataTypeString, Type: v3.AttributeKeyTypeUnspecified}},
|
||||||
},
|
},
|
||||||
want: "",
|
want: "trace_id != ''",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "exists top level column- number",
|
||||||
|
args: args{
|
||||||
|
op: v3.FilterOperatorNotExists,
|
||||||
|
item: v3.FilterItem{Key: v3.AttributeKey{Key: "severity_number", DataType: v3.AttributeKeyDataTypeArrayFloat64, Type: v3.AttributeKeyTypeUnspecified}},
|
||||||
|
},
|
||||||
|
want: "severity_number = 0",
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
for _, tt := range tests {
|
for _, tt := range tests {
|
||||||
|
Loading…
x
Reference in New Issue
Block a user