GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-18 17:35:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: update dashboards to use placeholder params (#3408)

Browse Source
This commit is contained in:
Srikanth Chekuri 2023-08-24 12:14:16 +05:30 committed by GitHub
parent 598e71eb8e
commit 0bee0a6d90
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
pkg/query-service/app/dashboards/model.go
View File

@ -49,7 +49,7 @@ func InitDB(dataSourceName string) (*sqlx.DB, error) {
_, err = db.Exec(table_schema) _, err = db.Exec(table_schema)
if err != nil { if err != nil {
return nil, fmt.Errorf("Error in creating dashboard table: %s", err.Error()) return nil, fmt.Errorf("error in creating dashboard table: %s", err.Error())
} }
table_schema = `CREATE TABLE IF NOT EXISTS rules ( table_schema = `CREATE TABLE IF NOT EXISTS rules (
@ -61,7 +61,7 @@ func InitDB(dataSourceName string) (*sqlx.DB, error) {
_, err = db.Exec(table_schema) _, err = db.Exec(table_schema)
if err != nil { if err != nil {
return nil, fmt.Errorf("Error in creating rules table: %s", err.Error()) return nil, fmt.Errorf("error in creating rules table: %s", err.Error())
} }
table_schema = `CREATE TABLE IF NOT EXISTS notification_channels ( table_schema = `CREATE TABLE IF NOT EXISTS notification_channels (
@ -76,7 +76,7 @@ func InitDB(dataSourceName string) (*sqlx.DB, error) {
_, err = db.Exec(table_schema) _, err = db.Exec(table_schema)
if err != nil { if err != nil {
return nil, fmt.Errorf("Error in creating notification_channles table: %s", err.Error()) return nil, fmt.Errorf("error in creating notification_channles table: %s", err.Error())
} }
table_schema = `CREATE TABLE IF NOT EXISTS ttl_status ( table_schema = `CREATE TABLE IF NOT EXISTS ttl_status (
@ -92,7 +92,7 @@ func InitDB(dataSourceName string) (*sqlx.DB, error) {
_, err = db.Exec(table_schema) _, err = db.Exec(table_schema)
if err != nil { if err != nil {
return nil, fmt.Errorf("Error in creating ttl_status table: %s", err.Error()) return nil, fmt.Errorf("error in creating ttl_status table: %s", err.Error())
} }
return db, nil return db, nil
@ -179,7 +179,7 @@ func CreateDashboard(data map[string]interface{}, fm interfaces.FeatureLookup) (
func GetDashboards() ([]Dashboard, *model.ApiError) { func GetDashboards() ([]Dashboard, *model.ApiError) {
dashboards := []Dashboard{} dashboards := []Dashboard{}
query := fmt.Sprintf("SELECT * FROM dashboards;") query := `SELECT * FROM dashboards`
err := db.Select(&dashboards, query) err := db.Select(&dashboards, query)
if err != nil { if err != nil {
@ -197,9 +197,9 @@ func DeleteDashboard(uuid string, fm interfaces.FeatureLookup) *model.ApiError {
return dErr return dErr
} }
query := fmt.Sprintf("DELETE FROM dashboards WHERE uuid='%s';", uuid) query := `DELETE FROM dashboards WHERE uuid=?`
result, err := db.Exec(query) result, err := db.Exec(query, uuid)
if err != nil { if err != nil {
return &model.ApiError{Typ: model.ErrorExec, Err: err} return &model.ApiError{Typ: model.ErrorExec, Err: err}
@ -224,9 +224,9 @@ func DeleteDashboard(uuid string, fm interfaces.FeatureLookup) *model.ApiError {
func GetDashboard(uuid string) (*Dashboard, *model.ApiError) { func GetDashboard(uuid string) (*Dashboard, *model.ApiError) {
dashboard := Dashboard{} dashboard := Dashboard{}
query := fmt.Sprintf("SELECT * FROM dashboards WHERE uuid='%s';", uuid) query := `SELECT * FROM dashboards WHERE uuid=?`
err := db.Get(&dashboard, query) err := db.Get(&dashboard, query, uuid)
if err != nil { if err != nil {
return nil, &model.ApiError{Typ: model.ErrorNotFound, Err: fmt.Errorf("no dashboard found with uuid: %s", uuid)} return nil, &model.ApiError{Typ: model.ErrorNotFound, Err: fmt.Errorf("no dashboard found with uuid: %s", uuid)}
} }