From 0c12eaf89b2a70a8c936bf505d389a39cf08b022 Mon Sep 17 00:00:00 2001
From: Raj Babu Das <mail.rajdas@gmail.com>
Date: Sat, 26 Jun 2021 00:44:13 +0530
Subject: [PATCH] adding download env step in  github workflow (#189)

* adding download env step in  github workflow

Signed-off-by: rajdas98 <mail.rajdas@gmail.com>

* adding download env step in  github workflow

Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
---
 .github/workflows/README.md |  4 ++--
 .github/workflows/push.yaml | 31 ++++++++++++++++++++++++++++++-
 2 files changed, 32 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/README.md b/.github/workflows/README.md
index 2535ecc9bb..6486823672 100644
--- a/.github/workflows/README.md
+++ b/.github/workflows/README.md
@@ -1,6 +1,6 @@
-To Run github workflow, few environment varibale needs to added in github secrets
+To run GitHub workflow, a few environment variables needs to add in GitHub secrets
 
-####  Tunables
+####  Environment Variables
 
 <table>
   <tr>
diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml
index 15e6ee7191..2adc8bbfd9 100644
--- a/.github/workflows/push.yaml
+++ b/.github/workflows/push.yaml
@@ -32,11 +32,12 @@ jobs:
           echo export FRONTEND_IMAGE="frontend" >> env-vars
           echo export QUERY_SERVICE="query-service" >> env-vars
           echo export FLATTENER_PROCESSOR="flattener-processor" >> env-vars
+
       - name: Uploading envs
         uses: actions/upload-artifact@v2
         with:
           name: env_artifact
-          path: env-vars
+          path: signoz/env-vars
 
   build-and-push-frontend:
     runs-on: ubuntu-latest
@@ -45,16 +46,25 @@ jobs:
     steps:
       - name: Checkout code
         uses: actions/checkout@v2
+
+      - name: Downloading image artficate
+        uses: actions/download-artifact@v2
+        with:
+          name: env_artifact
+          path: signoz
+
       - name: Build frontend docker image
         shell: bash
         run: |
           cd frontend
           docker build . -f Dockerfile
+
       - name: Login to DockerHub
         uses: docker/login-action@v1
         with:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_TOKEN }}
+
       - name: Push frontend docker image
         shell: bash
         run: |
@@ -73,16 +83,25 @@ jobs:
     steps:
       - name: Checkout code
         uses: actions/checkout@v2
+      
+      - name: Downloading image artficate
+        uses: actions/download-artifact@v2
+        with:
+          name: env_artifact
+          path: signoz
+
       - name: Build query-service image
         shell: bash
         run: |
           cd pkg/query-service
           docker build . -f Dockerfile
+
       - name: Login to DockerHub
         uses: docker/login-action@v1
         with:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_TOKEN }}
+
       - name: Push query service docker image
         shell: bash
         run: |
@@ -101,21 +120,31 @@ jobs:
     steps:
       - name: Checkout code
         uses: actions/checkout@v2
+
+      - name: Downloading image artficate
+        uses: actions/download-artifact@v2
+        with:
+          name: env_artifact
+          path: signoz
+
       - name: Build flattener docker image
         shell: bash
         run: |
           cd pkg/processors/flattener
           docker build . -f Dockerfile
+
       - name: Build flattener processor docker image
         shell: bash
         run: |
           cd pkg/query-service
           docker build . -f Dockerfile
+
       - name: Login to DockerHub
         uses: docker/login-action@v1
         with:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_TOKEN }}
+
       - name: Push flattener processor docker image
         shell: bash
         run: |