From 147476d8027db1debc1b1d8556dc5b7a12e82b06 Mon Sep 17 00:00:00 2001 From: palash-signoz Date: Thu, 5 May 2022 10:16:32 +0530 Subject: [PATCH] bug: confirm password bug is fixed (#1084) --- frontend/src/pages/SignUp/SignUp.tsx | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/frontend/src/pages/SignUp/SignUp.tsx b/frontend/src/pages/SignUp/SignUp.tsx index 7a8258cfab..1a99e0a5a5 100644 --- a/frontend/src/pages/SignUp/SignUp.tsx +++ b/frontend/src/pages/SignUp/SignUp.tsx @@ -178,6 +178,20 @@ function SignUp({ version }: SignUpProps): JSX.Element { const isNameVisible = getIsNameVisible(); + useEffect(() => { + if (!isPasswordValid(password) && password.length) { + setIsPasswordPolicyError(true); + } else { + setIsPasswordPolicyError(false); + } + + if (password !== confirmPassword) { + setConfirmPasswordError(true); + } else { + setConfirmPasswordError(false); + } + }, [password, confirmPassword]); + return ( @@ -246,16 +260,6 @@ function SignUp({ version }: SignUpProps): JSX.Element { onChange={(e): void => { const updateValue = e.target.value; setState(updateValue, setConfirmPassword); - if (password !== updateValue) { - setConfirmPasswordError(true); - } else { - setConfirmPasswordError(false); - } - if (!isPasswordValid(updateValue)) { - setIsPasswordPolicyError(true); - } else { - setIsPasswordPolicyError(false); - } }} required id="UpdatePassword"