From 1d77780c7016fe524576a78bad3f470645d2a2b8 Mon Sep 17 00:00:00 2001
From: Amlan Kumar Nandy <45410599+amlannandy@users.noreply.github.com>
Date: Fri, 30 May 2025 12:39:24 +0700
Subject: [PATCH] feat: add views tab to metrics explorer (#8091)

---
 .../src/container/MetricsExplorer/Views/Views.tsx    | 12 ------------
 .../src/container/MetricsExplorer/Views/index.ts     |  3 ---
 .../pages/MetricsExplorer/MetricsExplorerPage.tsx    |  4 ++--
 frontend/src/pages/MetricsExplorer/constants.tsx     |  4 ++--
 frontend/src/pages/SaveView/constants.ts             |  2 ++
 5 files changed, 6 insertions(+), 19 deletions(-)
 delete mode 100644 frontend/src/container/MetricsExplorer/Views/Views.tsx
 delete mode 100644 frontend/src/container/MetricsExplorer/Views/index.ts

diff --git a/frontend/src/container/MetricsExplorer/Views/Views.tsx b/frontend/src/container/MetricsExplorer/Views/Views.tsx
deleted file mode 100644
index 4b2bf65263..0000000000
--- a/frontend/src/container/MetricsExplorer/Views/Views.tsx
+++ /dev/null
@@ -1,12 +0,0 @@
-import * as Sentry from '@sentry/react';
-import ErrorBoundaryFallback from 'pages/ErrorBoundaryFallback/ErrorBoundaryFallback';
-
-function Views(): JSX.Element {
-	return (
-		<Sentry.ErrorBoundary fallback={<ErrorBoundaryFallback />}>
-			Views
-		</Sentry.ErrorBoundary>
-	);
-}
-
-export default Views;
diff --git a/frontend/src/container/MetricsExplorer/Views/index.ts b/frontend/src/container/MetricsExplorer/Views/index.ts
deleted file mode 100644
index 7893d1b90a..0000000000
--- a/frontend/src/container/MetricsExplorer/Views/index.ts
+++ /dev/null
@@ -1,3 +0,0 @@
-import Views from './Views';
-
-export default Views;
diff --git a/frontend/src/pages/MetricsExplorer/MetricsExplorerPage.tsx b/frontend/src/pages/MetricsExplorer/MetricsExplorerPage.tsx
index 1b416d4f64..7a13a65ac9 100644
--- a/frontend/src/pages/MetricsExplorer/MetricsExplorerPage.tsx
+++ b/frontend/src/pages/MetricsExplorer/MetricsExplorerPage.tsx
@@ -5,12 +5,12 @@ import { TabRoutes } from 'components/RouteTab/types';
 import history from 'lib/history';
 import { useLocation } from 'react-use';
 
-import { Explorer, Summary } from './constants';
+import { Explorer, Summary, Views } from './constants';
 
 function MetricsExplorerPage(): JSX.Element {
 	const { pathname } = useLocation();
 
-	const routes: TabRoutes[] = [Summary, Explorer];
+	const routes: TabRoutes[] = [Summary, Explorer, Views];
 
 	return (
 		<div className="metrics-explorer-page">
diff --git a/frontend/src/pages/MetricsExplorer/constants.tsx b/frontend/src/pages/MetricsExplorer/constants.tsx
index a1c12d0906..daad1775b5 100644
--- a/frontend/src/pages/MetricsExplorer/constants.tsx
+++ b/frontend/src/pages/MetricsExplorer/constants.tsx
@@ -2,8 +2,8 @@ import { TabRoutes } from 'components/RouteTab/types';
 import ROUTES from 'constants/routes';
 import ExplorerPage from 'container/MetricsExplorer/Explorer';
 import SummaryPage from 'container/MetricsExplorer/Summary';
-import ViewsPage from 'container/MetricsExplorer/Views';
 import { BarChart2, Compass, TowerControl } from 'lucide-react';
+import SaveView from 'pages/SaveView';
 
 export const Summary: TabRoutes = {
 	Component: SummaryPage,
@@ -28,7 +28,7 @@ export const Explorer: TabRoutes = {
 };
 
 export const Views: TabRoutes = {
-	Component: ViewsPage,
+	Component: SaveView,
 	name: (
 		<div className="tab-item">
 			<TowerControl size={16} /> Views
diff --git a/frontend/src/pages/SaveView/constants.ts b/frontend/src/pages/SaveView/constants.ts
index a6d55b1cb9..e07b3c8876 100644
--- a/frontend/src/pages/SaveView/constants.ts
+++ b/frontend/src/pages/SaveView/constants.ts
@@ -5,6 +5,7 @@ export const SOURCEPAGE_VS_ROUTES: {
 } = {
 	logs: ROUTES.LOGS_EXPLORER,
 	traces: ROUTES.TRACES_EXPLORER,
+	metrics: ROUTES.METRICS_EXPLORER_EXPLORER,
 } as const;
 
 export const ROUTES_VS_SOURCEPAGE: {
@@ -12,4 +13,5 @@ export const ROUTES_VS_SOURCEPAGE: {
 } = {
 	[ROUTES.LOGS_SAVE_VIEWS]: 'logs',
 	[ROUTES.TRACES_SAVE_VIEWS]: 'traces',
+	[ROUTES.METRICS_EXPLORER_VIEWS]: 'metrics',
 } as const;