GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-07-25 10:34:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: empty string search doesn't return all exceptions (#4346)

Browse Source 
* fix: empty string search doesn't return all exceptions

* fix: add type
This commit is contained in:
Yunus M 2024-01-10 14:07:23 +05:30 committed by GitHub
parent 6f5f361a7e
commit 1e679a0d64
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 30 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
frontend/src/container/AllError/index.tsx
View File

@ -48,6 +48,15 @@ import {
urlKey, urlKey,
} from './utils'; } from './utils';
type QueryParams = {
order: string;
offset: number;
orderParam: string;
pageSize: number;
exceptionType?: string;
serviceName?: string;
};
function AllErrors(): JSX.Element { function AllErrors(): JSX.Element {
const { maxTime, minTime, loading } = useSelector<AppState, GlobalReducer>( const { maxTime, minTime, loading } = useSelector<AppState, GlobalReducer>(
(state) => state.globalTime, (state) => state.globalTime,
@ -162,16 +171,23 @@ function AllErrors(): JSX.Element {
filterKey, filterKey,
filterValue || '', filterValue || '',
); );
history.replace(
`${pathname}?${createQueryParams({ const queryParams: QueryParams = {
order: updatedOrder, order: updatedOrder,
offset: getUpdatedOffset, offset: getUpdatedOffset,
orderParam: getUpdatedParams, orderParam: getUpdatedParams,
pageSize: getUpdatedPageSize, pageSize: getUpdatedPageSize,
exceptionType: exceptionFilterValue, };
serviceName: serviceFilterValue,
})}`, if (exceptionFilterValue && exceptionFilterValue !== 'undefined') {
); queryParams.exceptionType = exceptionFilterValue;
}
if (serviceFilterValue && serviceFilterValue !== 'undefined') {
queryParams.serviceName = serviceFilterValue;
}
history.replace(`${pathname}?${createQueryParams(queryParams)}`);
confirm(); confirm();
}, },
[ [
@ -198,8 +214,10 @@ function AllErrors(): JSX.Element {
<Input <Input
placeholder={placeholder} placeholder={placeholder}
value={selectedKeys[0]} value={selectedKeys[0]}
onChange={(e): void => onChange={
setSelectedKeys(e.target.value ? [e.target.value] : []) (e): void => setSelectedKeys(e.target.value ? [e.target.value] : [])
// Need to fix this logic, when the value in empty, it's setting undefined string as value
} }
allowClear allowClear
defaultValue={getDefaultFilterValue( defaultValue={getDefaultFilterValue(