From 2b3934b84570bca3d60cafb3341a4f82b6fc87c6 Mon Sep 17 00:00:00 2001
From: dnazarenkoo <134951516+dnazarenkoo@users.noreply.github.com>
Date: Fri, 7 Jul 2023 19:20:52 +0300
Subject: [PATCH] fix: add converting to ms for the durationNano attribute
 (#3072)

* fix: add converting to ms for the durationNano attrbute

* fix: add ms title to the graph

---------

Co-authored-by: Vishal Sharma <makeavish786@gmail.com>
---
 .../TimeSeriesView/TimeSeriesView.tsx         |  4 +++
 .../src/container/TimeSeriesView/index.tsx    | 36 +++++++++++++++++--
 .../src/container/TimeSeriesView/utils.ts     | 26 ++++++++++++++
 3 files changed, 64 insertions(+), 2 deletions(-)
 create mode 100644 frontend/src/container/TimeSeriesView/utils.ts

diff --git a/frontend/src/container/TimeSeriesView/TimeSeriesView.tsx b/frontend/src/container/TimeSeriesView/TimeSeriesView.tsx
index ca01a0156c..6824b23995 100644
--- a/frontend/src/container/TimeSeriesView/TimeSeriesView.tsx
+++ b/frontend/src/container/TimeSeriesView/TimeSeriesView.tsx
@@ -11,6 +11,7 @@ function TimeSeriesView({
 	data,
 	isLoading,
 	isError,
+	yAxisUnit,
 }: TimeSeriesViewProps): JSX.Element {
 	const chartData = useMemo(
 		() =>
@@ -32,6 +33,7 @@ function TimeSeriesView({
 				<Graph
 					animate={false}
 					data={chartData}
+					yAxisUnit={yAxisUnit}
 					name="tracesExplorerGraph"
 					type="line"
 				/>
@@ -42,12 +44,14 @@ function TimeSeriesView({
 
 interface TimeSeriesViewProps {
 	data?: SuccessResponse<MetricRangePayloadProps>;
+	yAxisUnit?: string;
 	isLoading: boolean;
 	isError: boolean;
 }
 
 TimeSeriesView.defaultProps = {
 	data: undefined,
+	yAxisUnit: 'short',
 };
 
 export default TimeSeriesView;
diff --git a/frontend/src/container/TimeSeriesView/index.tsx b/frontend/src/container/TimeSeriesView/index.tsx
index 5212334a4d..a0618b9960 100644
--- a/frontend/src/container/TimeSeriesView/index.tsx
+++ b/frontend/src/container/TimeSeriesView/index.tsx
@@ -2,23 +2,43 @@ import { initialQueriesMap, PANEL_TYPES } from 'constants/queryBuilder';
 import { REACT_QUERY_KEY } from 'constants/reactQueryKeys';
 import { useGetQueryRange } from 'hooks/queryBuilder/useGetQueryRange';
 import { useQueryBuilder } from 'hooks/queryBuilder/useQueryBuilder';
+import { useMemo } from 'react';
 import { useSelector } from 'react-redux';
 import { AppState } from 'store/reducers';
 import { DataSource } from 'types/common/queryBuilder';
 import { GlobalReducer } from 'types/reducer/globalTime';
 
 import TimeSeriesView from './TimeSeriesView';
+import { convertDataValueToMs } from './utils';
 
 function TimeSeriesViewContainer({
 	dataSource = DataSource.TRACES,
 }: TimeSeriesViewProps): JSX.Element {
-	const { stagedQuery, panelType } = useQueryBuilder();
+	const { stagedQuery, currentQuery, panelType } = useQueryBuilder();
 
 	const { selectedTime: globalSelectedTime, maxTime, minTime } = useSelector<
 		AppState,
 		GlobalReducer
 	>((state) => state.globalTime);
 
+	const isValidToConvertToMs = useMemo(() => {
+		const isValid: boolean[] = [];
+
+		currentQuery.builder.queryData.forEach(
+			({ aggregateAttribute, aggregateOperator }) => {
+				const isExistDurationNanoAttribute =
+					aggregateAttribute.key === 'durationNano';
+
+				const isCountOperator =
+					aggregateOperator === 'count' || aggregateOperator === 'count_distinct';
+
+				isValid.push(!isCountOperator && isExistDurationNanoAttribute);
+			},
+		);
+
+		return isValid.every(Boolean);
+	}, [currentQuery]);
+
 	const { data, isLoading, isError } = useGetQueryRange(
 		{
 			query: stagedQuery || initialQueriesMap[dataSource],
@@ -41,7 +61,19 @@ function TimeSeriesViewContainer({
 		},
 	);
 
-	return <TimeSeriesView isError={isError} isLoading={isLoading} data={data} />;
+	const responseData = useMemo(
+		() => (isValidToConvertToMs ? convertDataValueToMs(data) : data),
+		[data, isValidToConvertToMs],
+	);
+
+	return (
+		<TimeSeriesView
+			isError={isError}
+			isLoading={isLoading}
+			data={responseData}
+			yAxisUnit={isValidToConvertToMs ? 'ms' : 'short'}
+		/>
+	);
 }
 
 interface TimeSeriesViewProps {
diff --git a/frontend/src/container/TimeSeriesView/utils.ts b/frontend/src/container/TimeSeriesView/utils.ts
new file mode 100644
index 0000000000..b857cf9815
--- /dev/null
+++ b/frontend/src/container/TimeSeriesView/utils.ts
@@ -0,0 +1,26 @@
+import { SuccessResponse } from 'types/api/index';
+import { MetricRangePayloadProps } from 'types/api/metrics/getQueryRange';
+import { QueryData } from 'types/api/widgets/getQuery';
+
+export const convertDataValueToMs = (
+	data?: SuccessResponse<MetricRangePayloadProps>,
+): SuccessResponse<MetricRangePayloadProps> | undefined => {
+	const convertedData = data;
+
+	const convertedResult: QueryData[] = data?.payload?.data?.result
+		? data.payload.data.result.map((item) => {
+				const values: [number, string][] = item.values.map((value) => {
+					const [first = 0, second = ''] = value || [];
+					return [first, String(Number(second) / 1000000)];
+				});
+
+				return { ...item, values };
+		  })
+		: [];
+
+	if (convertedData?.payload?.data?.result && convertedResult) {
+		convertedData.payload.data.result = convertedResult;
+	}
+
+	return convertedData;
+};