GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-11 20:59:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #130 from SigNoz/refactor-redux

Browse Source 
refactor(FE: traceFilters): remove multiple reducers
This commit is contained in:
Ankit Nayan 2021-05-31 21:48:41 +05:30 committed by GitHub
commit 2eed75560d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 22 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
frontend/src/store/actions/traceFilters.ts
View File

@ -32,16 +32,4 @@ export const updateTraceFilters = (traceFilters: TraceFilters) => {
}; };
}; };
export interface updateInputTagAction {
type: ActionTypes.updateInput;
payload: string;
}
export const updateInputTag = (Input: string) => {
return {
type: ActionTypes.updateInput,
payload: Input,
};
};
//named export when you want to export multiple functions from the same file //named export when you want to export multiple functions from the same file

6
frontend/src/store/reducers/index.ts
View File

@ -25,13 +25,12 @@ import {
externalMetricsReducer, externalMetricsReducer,
externalAvgDurationMetricsReducer, externalAvgDurationMetricsReducer,
} from "./metrics"; } from "./metrics";
import { traceFiltersReducer, inputsReducer } from "./traceFilters"; import TraceFilterReducer from "./traceFilters";
import { traceItemReducer, tracesReducer } from "./traces"; import { traceItemReducer, tracesReducer } from "./traces";
import { usageDataReducer } from "./usage"; import { usageDataReducer } from "./usage";
import { ServiceMapReducer } from "./serviceMap"; import { ServiceMapReducer } from "./serviceMap";
export interface StoreState { export interface StoreState {
traceFilters: TraceFilters; traceFilters: TraceFilters;
inputTag: string;
traces: traceResponseNew; traces: traceResponseNew;
traceItem: spansWSameTraceIDResponse; traceItem: spansWSameTraceIDResponse;
servicesList: servicesListItem[]; servicesList: servicesListItem[];
@ -48,8 +47,7 @@ export interface StoreState {
} }
const reducers = combineReducers<StoreState>({ const reducers = combineReducers<StoreState>({
traceFilters: traceFiltersReducer, traceFilters: TraceFilterReducer,
inputTag: inputsReducer,
traces: tracesReducer, traces: tracesReducer,
traceItem: traceItemReducer, traceItem: traceItemReducer,
servicesList: serviceTableReducer, servicesList: serviceTableReducer,

13
frontend/src/store/reducers/serviceMap.ts
View File

@ -1,12 +1,11 @@
import { ActionTypes, Action, serviceMapStore } from "../actions"; import { ActionTypes, Action, serviceMapStore } from "../actions";
export const ServiceMapReducer = ( const initialState: serviceMapStore = {
state: serviceMapStore = { items: [],
items: [], services: [],
services: [], };
},
action: Action, export const ServiceMapReducer = (state = initialState, action: Action) => {
) => {
switch (action.type) { switch (action.type) {
case ActionTypes.getServiceMapItems: case ActionTypes.getServiceMapItems:
return { return {

40
frontend/src/store/reducers/traceFilters.ts
View File

@ -1,19 +1,17 @@
import { import { ActionTypes, TraceFilters } from "../actions";
ActionTypes,
TraceFilters,
updateInputTagAction,
updateTraceFiltersAction,
} from "../actions";
export const traceFiltersReducer = ( type ACTION = {
state: TraceFilters = { type: ActionTypes;
service: "", payload: TraceFilters;
tags: [], };
operation: "", const initialState: TraceFilters = {
latency: { min: "", max: "" }, service: "",
}, tags: [],
action: updateTraceFiltersAction, operation: "",
) => { latency: { min: "", max: "" },
};
const TraceFilterReducer = (state = initialState, action: ACTION) => {
switch (action.type) { switch (action.type) {
case ActionTypes.updateTraceFilters: case ActionTypes.updateTraceFilters:
return action.payload; return action.payload;
@ -22,14 +20,4 @@ export const traceFiltersReducer = (
} }
}; };
export const inputsReducer = ( export default TraceFilterReducer;
state: string = "",
action: updateInputTagAction,
) => {
switch (action.type) {
case ActionTypes.updateInput:
return action.payload;
default:
return state;
}
};