From 33ac5b79bed97e523e2dd77f8d46d5881823c512 Mon Sep 17 00:00:00 2001 From: Vishal Sharma Date: Wed, 26 Apr 2023 18:23:54 +0530 Subject: [PATCH] feat: add errorCount in top_operations API (#2636) --- pkg/query-service/app/clickhouseReader/reader.go | 1 + pkg/query-service/model/response.go | 1 + 2 files changed, 2 insertions(+) diff --git a/pkg/query-service/app/clickhouseReader/reader.go b/pkg/query-service/app/clickhouseReader/reader.go index 197997409f..39f9c38992 100644 --- a/pkg/query-service/app/clickhouseReader/reader.go +++ b/pkg/query-service/app/clickhouseReader/reader.go @@ -1854,6 +1854,7 @@ func (r *ClickHouseReader) GetTopOperations(ctx context.Context, queryParams *mo quantile(0.95)(durationNano) as p95, quantile(0.99)(durationNano) as p99, COUNT(*) as numCalls, + countIf(statusCode=2) as errorCount, name FROM %s.%s WHERE serviceName = @serviceName AND timestamp>= @start AND timestamp<= @end`, diff --git a/pkg/query-service/model/response.go b/pkg/query-service/model/response.go index d6a0570234..31d5a05ae6 100644 --- a/pkg/query-service/model/response.go +++ b/pkg/query-service/model/response.go @@ -272,6 +272,7 @@ type TopOperationsItem struct { Percentile95 float64 `json:"p95" ch:"p95"` Percentile99 float64 `json:"p99" ch:"p99"` NumCalls uint64 `json:"numCalls" ch:"numCalls"` + ErrorCount uint64 `json:"errorCount" ch:"errorCount"` Name string `json:"name" ch:"name"` }