From 357e422ecad96e4c37e6973bb42e81ed6ea4b639 Mon Sep 17 00:00:00 2001 From: Vishal Sharma Date: Thu, 18 May 2023 14:08:32 +0530 Subject: [PATCH] fix: add support for bool values in time series result (#2713) * fix: add support for bool values in time series result * chore: reserved target column can never be bool so removed obsolete code --------- Co-authored-by: Ankit Nayan Co-authored-by: Palash Gupta --- pkg/query-service/app/clickhouseReader/reader.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/pkg/query-service/app/clickhouseReader/reader.go b/pkg/query-service/app/clickhouseReader/reader.go index 39f9c38992..9b9c1b8beb 100644 --- a/pkg/query-service/app/clickhouseReader/reader.go +++ b/pkg/query-service/app/clickhouseReader/reader.go @@ -4096,8 +4096,12 @@ func readRow(vars []interface{}, columnNames []string) ([]string, map[string]str groupBy = append(groupBy, fmt.Sprintf("%v", reflect.ValueOf(v).Elem().Int())) groupAttributes[colName] = fmt.Sprintf("%v", reflect.ValueOf(v).Elem().Int()) } + case *bool: + groupBy = append(groupBy, fmt.Sprintf("%v", *v)) + groupAttributes[colName] = fmt.Sprintf("%v", *v) + default: - zap.S().Errorf("unsupported var type %v found in metric builder query result for column %s", v, colName) + zap.S().Errorf("unsupported var type %v found in query builder query result for column %s", v, colName) } } return groupBy, groupAttributes, point @@ -4424,4 +4428,4 @@ func (r *ClickHouseReader) GetSpanAttributeKeys(ctx context.Context) (map[string response[tagKey] = key } return response, nil -} \ No newline at end of file +}