GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-14 20:35:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: part of #1353, move db calls to prepared statement for checkttlstatusItem (#3976)

Browse Source 
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
This commit is contained in:
Srikanth Iyengar 2023-11-18 10:32:19 +05:30 committed by GitHub
parent bad69abcc2
commit 36aced6d1a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/query-service/app/clickhouseReader/reader.go
View File

@ -2456,11 +2456,18 @@ func (r *ClickHouseReader) deleteTtlTransactions(ctx context.Context, numberOfTr
func (r *ClickHouseReader) checkTTLStatusItem(ctx context.Context, tableName string) (model.TTLStatusItem, *model.ApiError) { func (r *ClickHouseReader) checkTTLStatusItem(ctx context.Context, tableName string) (model.TTLStatusItem, *model.ApiError) {
statusItem := []model.TTLStatusItem{} statusItem := []model.TTLStatusItem{}
query := fmt.Sprintf("SELECT id, status, ttl, cold_storage_ttl FROM ttl_status WHERE table_name = '%s' ORDER BY created_at DESC", tableName) query := `SELECT id, status, ttl, cold_storage_ttl FROM ttl_status WHERE table_name = ? ORDER BY created_at DESC`
err := r.localDB.Select(&statusItem, query) zap.S().Info(query, tableName)
zap.S().Info(query) stmt, err := r.localDB.Preparex(query)
if err != nil {
zap.S().Debug("Error preparing query for checkTTLStatusItem: ", err)
return model.TTLStatusItem{}, &model.ApiError{Typ: model.ErrorInternal, Err: err}
}
err = stmt.Select(&statusItem, tableName)
if len(statusItem) == 0 { if len(statusItem) == 0 {
return model.TTLStatusItem{}, nil return model.TTLStatusItem{}, nil