chore: add constants for standardisation in the API

Signed-off-by: Shivanshu Raj Shrivastava <shivanshu1333@gmail.com>
This commit is contained in:
Shivanshu Raj Shrivastava 2025-04-26 19:14:47 +05:30 committed by Sahil Khan
parent 2ce4b60c55
commit 3dce13d29f

View File

@ -1,8 +1,14 @@
package thirdPartyApi package thirdPartyApi
import ( import (
v3 "github.com/SigNoz/signoz/pkg/query-service/model/v3"
"net" "net"
v3 "github.com/SigNoz/signoz/pkg/query-service/model/v3"
)
const (
urlPathKey = "http.url"
serverNameKey = "net.peer.name"
) )
var defaultStepInterval int64 = 60 var defaultStepInterval int64 = 60
@ -17,7 +23,7 @@ func FilterResponse(results []*v3.Result) []*v3.Result {
filteredRows := make([]*v3.TableRow, 0, len(res.Table.Rows)) filteredRows := make([]*v3.TableRow, 0, len(res.Table.Rows))
for _, row := range res.Table.Rows { for _, row := range res.Table.Rows {
if row.Data != nil { if row.Data != nil {
if domainVal, ok := row.Data["net.peer.name"]; ok { if domainVal, ok := row.Data[serverNameKey]; ok {
if domainStr, ok := domainVal.(string); ok { if domainStr, ok := domainVal.(string); ok {
if net.ParseIP(domainStr) != nil { if net.ParseIP(domainStr) != nil {
continue continue
@ -63,7 +69,7 @@ func BuildDomainList(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
StepInterval: defaultStepInterval, StepInterval: defaultStepInterval,
AggregateOperator: v3.AggregateOperatorCountDistinct, AggregateOperator: v3.AggregateOperatorCountDistinct,
AggregateAttribute: v3.AttributeKey{ AggregateAttribute: v3.AttributeKey{
Key: "http.url", Key: urlPathKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
}, },
@ -74,7 +80,7 @@ func BuildDomainList(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
Items: getFilterSet([]v3.FilterItem{ Items: getFilterSet([]v3.FilterItem{
{ {
Key: v3.AttributeKey{ Key: v3.AttributeKey{
Key: "http.url", Key: urlPathKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
IsColumn: false, IsColumn: false,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
@ -96,7 +102,7 @@ func BuildDomainList(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
Expression: "endpoints", Expression: "endpoints",
GroupBy: getGroupBy([]v3.AttributeKey{ GroupBy: getGroupBy([]v3.AttributeKey{
{ {
Key: "net.peer.name", Key: serverNameKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
}, },
@ -122,7 +128,7 @@ func BuildDomainList(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
Items: getFilterSet([]v3.FilterItem{ Items: getFilterSet([]v3.FilterItem{
{ {
Key: v3.AttributeKey{ Key: v3.AttributeKey{
Key: "http.url", Key: urlPathKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
IsColumn: false, IsColumn: false,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
@ -144,7 +150,7 @@ func BuildDomainList(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
Expression: "lastseen", Expression: "lastseen",
GroupBy: getGroupBy([]v3.AttributeKey{ GroupBy: getGroupBy([]v3.AttributeKey{
{ {
Key: "net.peer.name", Key: serverNameKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
}, },
@ -170,7 +176,7 @@ func BuildDomainList(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
Items: getFilterSet([]v3.FilterItem{ Items: getFilterSet([]v3.FilterItem{
{ {
Key: v3.AttributeKey{ Key: v3.AttributeKey{
Key: "http.url", Key: urlPathKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
IsColumn: false, IsColumn: false,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
@ -192,7 +198,7 @@ func BuildDomainList(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
Expression: "rps", Expression: "rps",
GroupBy: getGroupBy([]v3.AttributeKey{ GroupBy: getGroupBy([]v3.AttributeKey{
{ {
Key: "net.peer.name", Key: serverNameKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
}, },
@ -228,7 +234,7 @@ func BuildDomainList(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
}, },
{ {
Key: v3.AttributeKey{ Key: v3.AttributeKey{
Key: "http.url", Key: urlPathKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
IsColumn: false, IsColumn: false,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
@ -250,7 +256,7 @@ func BuildDomainList(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
Expression: "error", Expression: "error",
GroupBy: getGroupBy([]v3.AttributeKey{ GroupBy: getGroupBy([]v3.AttributeKey{
{ {
Key: "net.peer.name", Key: serverNameKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
}, },
@ -329,7 +335,7 @@ func BuildDomainList(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
Items: getFilterSet([]v3.FilterItem{ Items: getFilterSet([]v3.FilterItem{
{ {
Key: v3.AttributeKey{ Key: v3.AttributeKey{
Key: "http.url", Key: urlPathKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
IsColumn: false, IsColumn: false,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
@ -351,7 +357,7 @@ func BuildDomainList(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
Expression: "p99", Expression: "p99",
GroupBy: getGroupBy([]v3.AttributeKey{ GroupBy: getGroupBy([]v3.AttributeKey{
{ {
Key: "net.peer.name", Key: serverNameKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
}, },
@ -401,7 +407,7 @@ func BuildDomainInfo(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
StepInterval: defaultStepInterval, StepInterval: defaultStepInterval,
AggregateOperator: v3.AggregateOperatorCount, AggregateOperator: v3.AggregateOperatorCount,
AggregateAttribute: v3.AttributeKey{ AggregateAttribute: v3.AttributeKey{
Key: "http.url", Key: urlPathKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
}, },
@ -412,7 +418,7 @@ func BuildDomainInfo(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
Items: getFilterSet([]v3.FilterItem{ Items: getFilterSet([]v3.FilterItem{
{ {
Key: v3.AttributeKey{ Key: v3.AttributeKey{
Key: "http.url", Key: urlPathKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
IsColumn: false, IsColumn: false,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
@ -435,7 +441,7 @@ func BuildDomainInfo(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
Disabled: false, Disabled: false,
GroupBy: getGroupBy([]v3.AttributeKey{ GroupBy: getGroupBy([]v3.AttributeKey{
{ {
Key: "http.url", Key: urlPathKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
}, },
@ -461,7 +467,7 @@ func BuildDomainInfo(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
Items: getFilterSet([]v3.FilterItem{ Items: getFilterSet([]v3.FilterItem{
{ {
Key: v3.AttributeKey{ Key: v3.AttributeKey{
Key: "http.url", Key: urlPathKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
IsColumn: false, IsColumn: false,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
@ -503,7 +509,7 @@ func BuildDomainInfo(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
Items: getFilterSet([]v3.FilterItem{ Items: getFilterSet([]v3.FilterItem{
{ {
Key: v3.AttributeKey{ Key: v3.AttributeKey{
Key: "http.url", Key: urlPathKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
IsColumn: false, IsColumn: false,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,
@ -544,7 +550,7 @@ func BuildDomainInfo(thirdPartyApis *ThirdPartyApis) (*v3.QueryRangeParamsV3, er
Items: getFilterSet([]v3.FilterItem{ Items: getFilterSet([]v3.FilterItem{
{ {
Key: v3.AttributeKey{ Key: v3.AttributeKey{
Key: "http.url", Key: urlPathKey,
DataType: v3.AttributeKeyDataTypeString, DataType: v3.AttributeKeyDataTypeString,
IsColumn: false, IsColumn: false,
Type: v3.AttributeKeyTypeTag, Type: v3.AttributeKeyTypeTag,