Merge branch 'main' of https://github.com/signoz/signoz into main

This commit is contained in:
Ankit Nayan 2021-05-02 20:54:05 +05:30
commit 3f176cda8d
2 changed files with 24 additions and 8 deletions

View File

@ -75,7 +75,7 @@ const columns = [
key: "errorRate", key: "errorRate",
sorter: (a: any, b: any) => a.errorRate - b.errorRate, sorter: (a: any, b: any) => a.errorRate - b.errorRate,
// sortDirections: ['descend', 'ascend'], // sortDirections: ['descend', 'ascend'],
render: (value: number) => (value * 100).toFixed(2), render: (value: number) => (value).toFixed(2),
}, },
{ {
title: "Requests Per Second", title: "Requests Per Second",

View File

@ -62,6 +62,10 @@ const _TraceFilter = (props: TraceFilterProps) => {
setServiceList(response.data); setServiceList(response.data);
}) })
.then(() => { .then(() => {
/*
Todo
revisit this flow post refactoring store
*/
const operationName = urlParams.get(METRICS_PAGE_QUERY_PARAM.operation); const operationName = urlParams.get(METRICS_PAGE_QUERY_PARAM.operation);
const serviceName = urlParams.get(METRICS_PAGE_QUERY_PARAM.service); const serviceName = urlParams.get(METRICS_PAGE_QUERY_PARAM.service);
const errorTag = urlParams.get(METRICS_PAGE_QUERY_PARAM.error); const errorTag = urlParams.get(METRICS_PAGE_QUERY_PARAM.error);
@ -72,6 +76,18 @@ const _TraceFilter = (props: TraceFilterProps) => {
service: serviceName, service: serviceName,
}); });
populateData(serviceName); populateData(serviceName);
} else if (serviceName && errorTag) {
props.updateTraceFilters({
...props.traceFilters,
service: serviceName,
tags: [
{
key: METRICS_PAGE_QUERY_PARAM.error,
value: errorTag,
operator: "equals",
},
],
});
} else { } else {
if (operationName) { if (operationName) {
handleChangeOperation(operationName); handleChangeOperation(operationName);
@ -79,13 +95,13 @@ const _TraceFilter = (props: TraceFilterProps) => {
if (serviceName) { if (serviceName) {
handleChangeService(serviceName); handleChangeService(serviceName);
} }
} if (errorTag) {
if (errorTag) { onTagFormSubmit({
onTagFormSubmit({ tag_key: METRICS_PAGE_QUERY_PARAM.error,
tag_key: METRICS_PAGE_QUERY_PARAM.error, tag_value: errorTag,
tag_value: errorTag, operator: "equals",
operator: "EQUAL", });
}); }
} }
}); });
}, []); }, []);