From 413caad0d8628f61c2194d430aae8e57624b6f72 Mon Sep 17 00:00:00 2001 From: shivanshu Date: Mon, 26 Aug 2024 17:58:55 +0530 Subject: [PATCH] chore: cleanup --- .../integrations/messagingQueues/kafka/sql.go | 43 ------------------- .../messagingQueues/kafka/translator.go | 17 -------- 2 files changed, 60 deletions(-) diff --git a/pkg/query-service/app/integrations/messagingQueues/kafka/sql.go b/pkg/query-service/app/integrations/messagingQueues/kafka/sql.go index b748109767..49e50a3d97 100644 --- a/pkg/query-service/app/integrations/messagingQueues/kafka/sql.go +++ b/pkg/query-service/app/integrations/messagingQueues/kafka/sql.go @@ -95,46 +95,3 @@ ORDER BY rps DESC `, end, start, start, end, queueType, consumerGroup) return query } - -func generateNetworkLatencyFetchSQL(step, start, end int64, clientId, serviceName string) string { - query := fmt.Sprintf(` ---- metrics aggregation, desc sorted by value -WITH filtered_time_series AS ( - SELECT DISTINCT - JSONExtractString(labels, 'service_instance_id') as service_instance_id, - JSONExtractString(labels, 'service_name') as service_name, - fingerprint - FROM signoz_metrics.time_series_v4_1day - WHERE metric_name = 'kafka_consumer_fetch_latency_avg' - AND temporality = 'Unspecified' - AND unix_milli >= '%d' - AND unix_milli < '%d' - AND JSONExtractString(labels, 'service_name') = '%s' - AND JSONExtractString(labels, 'client_id') = '%s' -), -aggregated_data AS ( - SELECT - fingerprint, - any(service_instance_id) as service_instance_id, - any(service_name) as service_name, - toStartOfInterval(toDateTime(intDiv(unix_milli, 1000)), INTERVAL '%d' SECOND) as ts, - avg(value) as per_series_value - FROM signoz_metrics.distributed_samples_v4 - INNER JOIN filtered_time_series USING fingerprint - WHERE metric_name = 'kafka_consumer_fetch_latency_avg' - AND unix_milli >= '%d' - AND unix_milli < '%d' - GROUP BY fingerprint, ts - ORDER BY fingerprint, ts -) -SELECT - service_name, - service_instance_id, - avg(per_series_value) as value -FROM aggregated_data -WHERE isNaN(per_series_value) = 0 -GROUP BY service_name, service_instance_id -ORDER BY value DESC -`, start, end, serviceName, clientId, step, start, end) - return query -} diff --git a/pkg/query-service/app/integrations/messagingQueues/kafka/translator.go b/pkg/query-service/app/integrations/messagingQueues/kafka/translator.go index c6e85b1608..ef7e7049ba 100644 --- a/pkg/query-service/app/integrations/messagingQueues/kafka/translator.go +++ b/pkg/query-service/app/integrations/messagingQueues/kafka/translator.go @@ -50,23 +50,6 @@ func buildClickHouseQueryNetwork(messagingQueue *MessagingQueue, queueType strin }, nil } -//func buildClickHouseQueriesNetwork(messagingQueue *MessagingQueue, attributeCache []Clients) (map[string]*v3.ClickHouseQuery, error) { -// cq := make(map[string]*v3.ClickHouseQuery) -// start := messagingQueue.Start -// end := messagingQueue.End -// -// for i, clientInfo := range attributeCache { -// query := generateNetworkLatencyFetchSQL(defaultStepInterval, start/1000000, end/1000000, clientInfo.ConsumerId, clientInfo.ServiceName) -// chq := &v3.ClickHouseQuery{ -// Query: query, -// } -// index := fmt.Sprintf("latency_%d", i) -// cq[index] = chq -// } -// -// return cq, nil -//} - func buildBuilderQueriesNetwork(attributeCache []Clients) (map[string]*v3.BuilderQuery, error) { bq := make(map[string]*v3.BuilderQuery)