GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-07-31 04:51:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: go to traces should use start time and end time from trace details (#5326)

Browse Source 
* feat: go to traces should use start time and endtime from trace details

* chore: remove console log

---------

Co-authored-by: Vishal Sharma <makeavish786@gmail.com>
This commit is contained in:
Yunus M 2024-06-24 16:57:05 +05:30 committed by GitHub
parent 89b67b8880
commit 415057c260
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 22 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
frontend/src/container/TraceDetail/SelectedSpanDetails/index.tsx
View File

@ -19,12 +19,17 @@ import { CardContainer, CustomSubText, styles } from './styles';
import Tags from './Tags';
function SelectedSpanDetails(props: SelectedSpanDetailsProps): JSX.Element {
const { tree, firstSpanStartTime } = props;
const { maxTime, minTime } = useSelector<AppState, GlobalReducer>(
(state) => state.globalTime,
);
const {
tree,
firstSpanStartTime,
traceStartTime = minTime,
traceEndTime = maxTime,
} = props;
const { id: traceId } = useParams<Params>();
const isDarkMode = useIsDarkMode();
@ -74,7 +79,7 @@ function SelectedSpanDetails(props: SelectedSpanDetailsProps): JSX.Element {
];
const onLogsHandler = (): void => {
const query = getTraceToLogsQuery(traceId, minTime, maxTime);
const query = getTraceToLogsQuery(traceId, traceStartTime, traceEndTime);
history.push(
`${ROUTES.LOGS_EXPLORER}?${createQueryParams({
@ -140,10 +145,14 @@ function SelectedSpanDetails(props: SelectedSpanDetailsProps): JSX.Element {
interface SelectedSpanDetailsProps {
tree?: ITraceTree;
firstSpanStartTime: number;
traceStartTime?: number;
traceEndTime?: number;
}
SelectedSpanDetails.defaultProps = {
tree: undefined,
traceStartTime: undefined,
traceEndTime: undefined,
};
export interface ModalText {

8
frontend/src/container/TraceDetail/index.tsx
View File

@ -48,6 +48,12 @@ function TraceDetail({ response }: TraceDetailProps): JSX.Element {
[response],
);
const traceStartTime = useMemo(() => response[0].startTimestampMillis, [
response,
]);
const traceEndTime = useMemo(() => response[0].endTimestampMillis, [response]);
const urlQuery = useUrlQuery();
const [spanId] = useState<string | null>(urlQuery.get('spanId'));
@ -260,6 +266,8 @@ function TraceDetail({ response }: TraceDetailProps): JSX.Element {
<StyledCol styledclass={[styles.selectedSpanDetailContainer]}>
<SelectedSpanDetails
firstSpanStartTime={firstSpanStartTime}
traceStartTime={traceStartTime}
traceEndTime={traceEndTime}
tree={[
...(getSelectedNode.spanTree ? getSelectedNode.spanTree : []),
...(getSelectedNode.missingSpanTree

2
frontend/src/types/api/trace/getTraceItem.ts
View File

@ -15,6 +15,8 @@ export interface PayloadProps {
segmentID: string;
columns: string[];
isSubTree: boolean;
startTimestampMillis: number;
endTimestampMillis: number;
};
}