mirror of
https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz
synced 2025-08-01 02:32:05 +08:00
feat: go to traces should use start time and end time from trace details (#5326)
* feat: go to traces should use start time and endtime from trace details * chore: remove console log --------- Co-authored-by: Vishal Sharma <makeavish786@gmail.com>
This commit is contained in:
parent
89b67b8880
commit
415057c260
@ -19,12 +19,17 @@ import { CardContainer, CustomSubText, styles } from './styles';
|
|||||||
import Tags from './Tags';
|
import Tags from './Tags';
|
||||||
|
|
||||||
function SelectedSpanDetails(props: SelectedSpanDetailsProps): JSX.Element {
|
function SelectedSpanDetails(props: SelectedSpanDetailsProps): JSX.Element {
|
||||||
const { tree, firstSpanStartTime } = props;
|
|
||||||
|
|
||||||
const { maxTime, minTime } = useSelector<AppState, GlobalReducer>(
|
const { maxTime, minTime } = useSelector<AppState, GlobalReducer>(
|
||||||
(state) => state.globalTime,
|
(state) => state.globalTime,
|
||||||
);
|
);
|
||||||
|
|
||||||
|
const {
|
||||||
|
tree,
|
||||||
|
firstSpanStartTime,
|
||||||
|
traceStartTime = minTime,
|
||||||
|
traceEndTime = maxTime,
|
||||||
|
} = props;
|
||||||
|
|
||||||
const { id: traceId } = useParams<Params>();
|
const { id: traceId } = useParams<Params>();
|
||||||
|
|
||||||
const isDarkMode = useIsDarkMode();
|
const isDarkMode = useIsDarkMode();
|
||||||
@ -74,7 +79,7 @@ function SelectedSpanDetails(props: SelectedSpanDetailsProps): JSX.Element {
|
|||||||
];
|
];
|
||||||
|
|
||||||
const onLogsHandler = (): void => {
|
const onLogsHandler = (): void => {
|
||||||
const query = getTraceToLogsQuery(traceId, minTime, maxTime);
|
const query = getTraceToLogsQuery(traceId, traceStartTime, traceEndTime);
|
||||||
|
|
||||||
history.push(
|
history.push(
|
||||||
`${ROUTES.LOGS_EXPLORER}?${createQueryParams({
|
`${ROUTES.LOGS_EXPLORER}?${createQueryParams({
|
||||||
@ -140,10 +145,14 @@ function SelectedSpanDetails(props: SelectedSpanDetailsProps): JSX.Element {
|
|||||||
interface SelectedSpanDetailsProps {
|
interface SelectedSpanDetailsProps {
|
||||||
tree?: ITraceTree;
|
tree?: ITraceTree;
|
||||||
firstSpanStartTime: number;
|
firstSpanStartTime: number;
|
||||||
|
traceStartTime?: number;
|
||||||
|
traceEndTime?: number;
|
||||||
}
|
}
|
||||||
|
|
||||||
SelectedSpanDetails.defaultProps = {
|
SelectedSpanDetails.defaultProps = {
|
||||||
tree: undefined,
|
tree: undefined,
|
||||||
|
traceStartTime: undefined,
|
||||||
|
traceEndTime: undefined,
|
||||||
};
|
};
|
||||||
|
|
||||||
export interface ModalText {
|
export interface ModalText {
|
||||||
|
@ -48,6 +48,12 @@ function TraceDetail({ response }: TraceDetailProps): JSX.Element {
|
|||||||
[response],
|
[response],
|
||||||
);
|
);
|
||||||
|
|
||||||
|
const traceStartTime = useMemo(() => response[0].startTimestampMillis, [
|
||||||
|
response,
|
||||||
|
]);
|
||||||
|
|
||||||
|
const traceEndTime = useMemo(() => response[0].endTimestampMillis, [response]);
|
||||||
|
|
||||||
const urlQuery = useUrlQuery();
|
const urlQuery = useUrlQuery();
|
||||||
const [spanId] = useState<string | null>(urlQuery.get('spanId'));
|
const [spanId] = useState<string | null>(urlQuery.get('spanId'));
|
||||||
|
|
||||||
@ -260,6 +266,8 @@ function TraceDetail({ response }: TraceDetailProps): JSX.Element {
|
|||||||
<StyledCol styledclass={[styles.selectedSpanDetailContainer]}>
|
<StyledCol styledclass={[styles.selectedSpanDetailContainer]}>
|
||||||
<SelectedSpanDetails
|
<SelectedSpanDetails
|
||||||
firstSpanStartTime={firstSpanStartTime}
|
firstSpanStartTime={firstSpanStartTime}
|
||||||
|
traceStartTime={traceStartTime}
|
||||||
|
traceEndTime={traceEndTime}
|
||||||
tree={[
|
tree={[
|
||||||
...(getSelectedNode.spanTree ? getSelectedNode.spanTree : []),
|
...(getSelectedNode.spanTree ? getSelectedNode.spanTree : []),
|
||||||
...(getSelectedNode.missingSpanTree
|
...(getSelectedNode.missingSpanTree
|
||||||
|
@ -15,6 +15,8 @@ export interface PayloadProps {
|
|||||||
segmentID: string;
|
segmentID: string;
|
||||||
columns: string[];
|
columns: string[];
|
||||||
isSubTree: boolean;
|
isSubTree: boolean;
|
||||||
|
startTimestampMillis: number;
|
||||||
|
endTimestampMillis: number;
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user