feat: limit & order by is enabled in the metrics query builder (#3566)

* feat: limit filter is enabled in the metrics filters

* chore: orderBy is enabled for metrics data source

* chore: fix table type limit and order by

---------

Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>

frontend/src/container/QueryBuilder/components/Query/Query.tsx

@@ -151,7 +151,6 @@ export const Query = memo(function Query({
 			case PANEL_TYPES.TIME_SERIES: {
 				return (
 					<>
-						{!isMetricsDataSource && (
 						<Col span={11}>
 							<Row gutter={[11, 5]}>
 								<Col flex="5.93rem">
@@ -162,7 +161,6 @@ export const Query = memo(function Query({
 								</Col>
 							</Row>
 						</Col>
-						)}
 						<Col span={11}>
 							<Row gutter={[11, 5]}>
 								<Col flex="5.93rem">
@@ -173,7 +171,6 @@ export const Query = memo(function Query({
 								</Col>
 							</Row>
 						</Col>
-						{!isMetricsDataSource && (
 						<Col span={11}>
 							<Row gutter={[11, 5]}>
 								<Col flex="5.93rem">
@@ -182,7 +179,6 @@ export const Query = memo(function Query({
 								<Col flex="1 1 12.5rem">{renderOrderByFilter()}</Col>
 							</Row>
 						</Col>
-						)}
 
 						<Col span={11}>{renderAggregateEveryFilter()}</Col>
 					</>
@@ -251,7 +247,6 @@ export const Query = memo(function Query({
 		}
 	}, [
 		panelType,
-		isMetricsDataSource,
 		query,
 		filterConfigs?.limit?.isHidden,
 		filterConfigs?.having?.isHidden,

frontend/src/hooks/queryBuilder/useQueryOperations.ts

@@ -7,7 +7,7 @@ import {
 import { useQueryBuilder } from 'hooks/queryBuilder/useQueryBuilder';
 import { getOperatorsBySourceAndPanelType } from 'lib/newQueryBuilder/getOperatorsBySourceAndPanelType';
 import { findDataTypeOfOperator } from 'lib/query/findDataTypeOfOperator';
-import { useCallback, useEffect, useMemo, useState } from 'react';
+import { useCallback, useEffect, useState } from 'react';
 import { BaseAutocompleteData } from 'types/api/queryBuilder/queryAutocompleteResponse';
 import { IBuilderQuery } from 'types/api/queryBuilder/queryBuilderData';
 import {
@@ -148,13 +148,9 @@ export const useQueryOperations: UseQueryOperations = ({
 		[query, index, handleSetQueryData],
 	);
 
-	const isMetricsDataSource = useMemo(
+	const isMetricsDataSource = query.dataSource === DataSource.METRICS;
-		() => query.dataSource === DataSource.METRICS,
+
-		[query.dataSource],
+	const isTracePanelType = panelType === PANEL_TYPES.TRACE;
-	);
-	const isTracePanelType = useMemo(() => panelType === PANEL_TYPES.TRACE, [
-		panelType,
-	]);
 
 	useEffect(() => {
 		if (initialDataSource && dataSource !== initialDataSource) return;

pkg/query-service/app/http_handler.go

@@ -3062,7 +3062,7 @@ func applyMetricLimit(results []*v3.Result, queryRangeParams *v3.QueryRangeParam
 			limit := builderQueries[result.QueryName].Limit
 
 			orderByList := builderQueries[result.QueryName].OrderBy
-			if limit != 0 {
+			if limit >= 0 {
 				if len(orderByList) == 0 {
 					// If no orderBy is specified, sort by value in descending order
 					orderByList = []v3.OrderBy{{ColumnName: constants.SigNozOrderByValue, Order: "desc"}}
@@ -3070,6 +3070,18 @@ func applyMetricLimit(results []*v3.Result, queryRangeParams *v3.QueryRangeParam
 				sort.SliceStable(result.Series, func(i, j int) bool {
 					for _, orderBy := range orderByList {
 						if orderBy.ColumnName == constants.SigNozOrderByValue {
+
+							// For table type queries (we rely on the fact that one value for row), sort
+							// based on final aggregation value
+							if len(result.Series[i].Points) == 1 && len(result.Series[j].Points) == 1 {
+								if orderBy.Order == "asc" {
+									return result.Series[i].Points[0].Value < result.Series[j].Points[0].Value
+								} else if orderBy.Order == "desc" {
+									return result.Series[i].Points[0].Value > result.Series[j].Points[0].Value
+								}
+							}
+
+							// For graph type queries, sort based on GroupingSetsPoint
 							if result.Series[i].GroupingSetsPoint == nil || result.Series[j].GroupingSetsPoint == nil {
 								// Handle nil GroupingSetsPoint, if needed
 								// Here, we assume non-nil values are always less than nil values
@@ -3102,7 +3114,7 @@ func applyMetricLimit(results []*v3.Result, queryRangeParams *v3.QueryRangeParam
 					return i < j
 				})
 
-				if len(result.Series) > int(limit) {
+				if limit > 0 && len(result.Series) > int(limit) {
 					result.Series = result.Series[:limit]
 				}
 			}