From 44dc55c5acbe9c5fed278e1d319d117e1193650e Mon Sep 17 00:00:00 2001
From: Rajat Dabade <rajat@signoz.io>
Date: Wed, 13 Mar 2024 17:37:48 +0530
Subject: [PATCH] FE: Design update for log context tab (#4601)

* refactor: initial setup for context view

* refactor: updated design for log context view

* refactor: updated comments and remove commented code

* refactor: updated comments

* refactor: handle hight issue

* refactor: initial setup for context view

* refactor: updated design for log context view

* refactor: updated comments and remove commented code

* refactor: updated comments

* refactor: handle hight issue

* refactor: added api version

* refactor: height set to parent height and remove unnessarry code

* refactor: removed commented code

---------

Co-authored-by: Yunus M <myounis.ar@live.com>
---
 .../LogDetail/LogDetails.styles.scss          |   2 +
 .../src/components/Logs/RawLogView/index.tsx  |   6 +-
 .../ContextLogRenderer.styles.scss            |  25 +++
 .../ContextView/ContextLogRenderer.tsx        | 129 ++++++++++++++
 .../ContextView/ContextView.styles.scss       |  22 ++-
 .../ContextView/ContextView.tsx               |  24 +--
 .../ContextView/useContextLogData.ts          | 163 ++++++++++++++++++
 7 files changed, 348 insertions(+), 23 deletions(-)
 create mode 100644 frontend/src/container/LogDetailedView/ContextView/ContextLogRenderer.styles.scss
 create mode 100644 frontend/src/container/LogDetailedView/ContextView/ContextLogRenderer.tsx
 create mode 100644 frontend/src/container/LogDetailedView/ContextView/useContextLogData.ts

diff --git a/frontend/src/components/LogDetail/LogDetails.styles.scss b/frontend/src/components/LogDetail/LogDetails.styles.scss
index 0dcdc1e5c1..c8ac0be91f 100644
--- a/frontend/src/components/LogDetail/LogDetails.styles.scss
+++ b/frontend/src/components/LogDetail/LogDetails.styles.scss
@@ -18,6 +18,8 @@
 	}
 
 	.ant-drawer-body {
+		display: flex;
+		flex-direction: column;
 		padding: 16px;
 	}
 
diff --git a/frontend/src/components/Logs/RawLogView/index.tsx b/frontend/src/components/Logs/RawLogView/index.tsx
index 419bb33a76..099e0fcc25 100644
--- a/frontend/src/components/Logs/RawLogView/index.tsx
+++ b/frontend/src/components/Logs/RawLogView/index.tsx
@@ -163,7 +163,11 @@ function RawLogView({
 		>
 			<LogStateIndicator
 				type={logType}
-				isActive={activeLog?.id === data.id || activeContextLog?.id === data.id}
+				isActive={
+					activeLog?.id === data.id ||
+					activeContextLog?.id === data.id ||
+					isActiveLog
+				}
 			/>
 
 			<RawLogContent
diff --git a/frontend/src/container/LogDetailedView/ContextView/ContextLogRenderer.styles.scss b/frontend/src/container/LogDetailedView/ContextView/ContextLogRenderer.styles.scss
new file mode 100644
index 0000000000..c8891390f4
--- /dev/null
+++ b/frontend/src/container/LogDetailedView/ContextView/ContextLogRenderer.styles.scss
@@ -0,0 +1,25 @@
+.context-log-renderer {
+    .virtuoso-list {
+        overflow-y: hidden !important;
+		&::-webkit-scrollbar {
+			width: 0.3rem;
+			height: 0.3rem;
+		}
+
+        &::-webkit-scrollbar-track {
+            background: transparent;
+        }
+
+        &::-webkit-scrollbar-thumb {
+            background: var(--bg-slate-300);
+        }
+
+        &::-webkit-scrollbar-thumb:hover {
+            background: var(--bg-slate-200);
+        }
+        
+        .ant-row {
+            width: fit-content;
+        }
+	}
+}
\ No newline at end of file
diff --git a/frontend/src/container/LogDetailedView/ContextView/ContextLogRenderer.tsx b/frontend/src/container/LogDetailedView/ContextView/ContextLogRenderer.tsx
new file mode 100644
index 0000000000..f80e706d30
--- /dev/null
+++ b/frontend/src/container/LogDetailedView/ContextView/ContextLogRenderer.tsx
@@ -0,0 +1,129 @@
+import './ContextLogRenderer.styles.scss';
+
+import { Skeleton } from 'antd';
+import RawLogView from 'components/Logs/RawLogView';
+import ShowButton from 'container/LogsContextList/ShowButton';
+import { ORDERBY_FILTERS } from 'container/QueryBuilder/filters/OrderByFilter/config';
+import { useCallback, useEffect, useState } from 'react';
+import { Virtuoso } from 'react-virtuoso';
+import { ILog } from 'types/api/logs/log';
+import { Query, TagFilter } from 'types/api/queryBuilder/queryBuilderData';
+
+import { useContextLogData } from './useContextLogData';
+
+function ContextLogRenderer({
+	isEdit,
+	query,
+	log,
+	filters,
+}: ContextLogRendererProps): JSX.Element {
+	const [prevLogPage, setPrevLogPage] = useState<number>(1);
+	const [afterLogPage, setAfterLogPage] = useState<number>(1);
+	const [logs, setLogs] = useState<ILog[]>([log]);
+
+	const {
+		logs: previousLogs,
+		isFetching: isPreviousLogsFetching,
+		handleShowNextLines: handlePreviousLogsShowNextLine,
+	} = useContextLogData({
+		log,
+		filters,
+		isEdit,
+		query,
+		order: ORDERBY_FILTERS.ASC,
+		page: prevLogPage,
+		setPage: setPrevLogPage,
+	});
+
+	const {
+		logs: afterLogs,
+		isFetching: isAfterLogsFetching,
+		handleShowNextLines: handleAfterLogsShowNextLine,
+	} = useContextLogData({
+		log,
+		filters,
+		isEdit,
+		query,
+		order: ORDERBY_FILTERS.DESC,
+		page: afterLogPage,
+		setPage: setAfterLogPage,
+	});
+
+	useEffect(() => {
+		setLogs((prev) => [...previousLogs, ...prev]);
+		// eslint-disable-next-line react-hooks/exhaustive-deps
+	}, [previousLogs]);
+
+	useEffect(() => {
+		setLogs((prev) => [...prev, ...afterLogs]);
+		// eslint-disable-next-line react-hooks/exhaustive-deps
+	}, [afterLogs]);
+
+	useEffect(() => {
+		setLogs([log]);
+		// eslint-disable-next-line react-hooks/exhaustive-deps
+	}, [filters]);
+
+	const getItemContent = useCallback(
+		(_: number, logTorender: ILog): JSX.Element => (
+			<RawLogView
+				isActiveLog={logTorender.id === log.id}
+				isReadOnly
+				isTextOverflowEllipsisDisabled
+				key={logTorender.id}
+				data={logTorender}
+				linesPerRow={1}
+			/>
+		),
+		[log.id],
+	);
+
+	return (
+		<div className="context-log-renderer">
+			<ShowButton
+				isLoading={isPreviousLogsFetching}
+				isDisabled={false}
+				order={ORDERBY_FILTERS.ASC}
+				onClick={handlePreviousLogsShowNextLine}
+			/>
+			{isPreviousLogsFetching && (
+				<Skeleton
+					style={{
+						height: '100%',
+						padding: '16px',
+					}}
+				/>
+			)}
+			<Virtuoso
+				className="virtuoso-list"
+				initialTopMostItemIndex={0}
+				data={logs}
+				itemContent={getItemContent}
+				style={{ height: `calc(${logs.length} * 32px)` }}
+			/>
+			{isAfterLogsFetching && (
+				<Skeleton
+					style={{
+						height: '100%',
+						padding: '16px',
+					}}
+				/>
+			)}
+			<ShowButton
+				isLoading={isAfterLogsFetching}
+				isDisabled={false}
+				order={ORDERBY_FILTERS.DESC}
+				onClick={handleAfterLogsShowNextLine}
+			/>
+		</div>
+	);
+}
+
+interface ContextLogRendererProps {
+	isEdit: boolean;
+	query: Query;
+	log: ILog;
+	filters: TagFilter | null;
+}
+
+export default ContextLogRenderer;
diff --git a/frontend/src/container/LogDetailedView/ContextView/ContextView.styles.scss b/frontend/src/container/LogDetailedView/ContextView/ContextView.styles.scss
index bc8ae4f719..bfb267b607 100644
--- a/frontend/src/container/LogDetailedView/ContextView/ContextView.styles.scss
+++ b/frontend/src/container/LogDetailedView/ContextView/ContextView.styles.scss
@@ -1,3 +1,23 @@
 .log-context-container {
     border: 1px solid var(--bg-slate-400);
-}
\ No newline at end of file
+    flex: 1;
+    position: relative;
+    overflow: scroll;
+    overflow-x: hidden;
+
+    &::-webkit-scrollbar {
+        width: 0.3rem;
+    }
+
+    &::-webkit-scrollbar-track {
+        background: transparent; 
+    }
+    
+    &::-webkit-scrollbar-thumb {
+        background: var(--bg-slate-300);
+    }
+    
+    &::-webkit-scrollbar-thumb:hover {
+        background: var(--bg-slate-200);
+    }
+}
diff --git a/frontend/src/container/LogDetailedView/ContextView/ContextView.tsx b/frontend/src/container/LogDetailedView/ContextView/ContextView.tsx
index e3a3c2d67b..fbb3f611f3 100644
--- a/frontend/src/container/LogDetailedView/ContextView/ContextView.tsx
+++ b/frontend/src/container/LogDetailedView/ContextView/ContextView.tsx
@@ -1,11 +1,10 @@
 import './ContextView.styles.scss';
 
-import RawLogView from 'components/Logs/RawLogView';
-import LogsContextList from 'container/LogsContextList';
-import { ORDERBY_FILTERS } from 'container/QueryBuilder/filters/OrderByFilter/config';
 import { ILog } from 'types/api/logs/log';
 import { Query, TagFilter } from 'types/api/queryBuilder/queryBuilderData';
 
+import ContextLogRenderer from './ContextLogRenderer';
+
 interface LogContextProps {
 	log: ILog;
 	contextQuery: Query | undefined;
@@ -24,28 +23,11 @@ function ContextView({
 
 	return (
 		<div className="log-context-container">
-			<LogsContextList
-				className="logs-context-list-asc"
-				order={ORDERBY_FILTERS.ASC}
+			<ContextLogRenderer
 				filters={filters}
-				isEdit={isEdit}
 				log={log}
 				query={contextQuery}
-			/>
-			<RawLogView
-				isActiveLog
-				isReadOnly
-				isTextOverflowEllipsisDisabled={false}
-				data={log}
-				linesPerRow={1}
-			/>
-			<LogsContextList
-				className="logs-context-list-desc"
-				order={ORDERBY_FILTERS.DESC}
-				filters={filters}
 				isEdit={isEdit}
-				log={log}
-				query={contextQuery}
 			/>
 		</div>
 	);
diff --git a/frontend/src/container/LogDetailedView/ContextView/useContextLogData.ts b/frontend/src/container/LogDetailedView/ContextView/useContextLogData.ts
new file mode 100644
index 0000000000..5a0ef84741
--- /dev/null
+++ b/frontend/src/container/LogDetailedView/ContextView/useContextLogData.ts
@@ -0,0 +1,163 @@
+import { DEFAULT_ENTITY_VERSION } from 'constants/app';
+import { PANEL_TYPES } from 'constants/queryBuilder';
+import {
+	getOrderByTimestamp,
+	INITIAL_PAGE_SIZE,
+	LOGS_MORE_PAGE_SIZE,
+} from 'container/LogsContextList/configs';
+import { getRequestData } from 'container/LogsContextList/utils';
+import { ORDERBY_FILTERS } from 'container/QueryBuilder/filters/OrderByFilter/config';
+import { useGetExplorerQueryRange } from 'hooks/queryBuilder/useGetExplorerQueryRange';
+import {
+	Dispatch,
+	SetStateAction,
+	useCallback,
+	useEffect,
+	useMemo,
+	useState,
+} from 'react';
+import { SuccessResponse } from 'types/api';
+import { ILog } from 'types/api/logs/log';
+import { MetricRangePayloadProps } from 'types/api/metrics/getQueryRange';
+import { Query, TagFilter } from 'types/api/queryBuilder/queryBuilderData';
+
+export const useContextLogData = ({
+	log,
+	query,
+	order,
+	isEdit,
+	filters,
+	page,
+	setPage,
+}: {
+	log: ILog;
+	query: Query;
+	order: string;
+	isEdit: boolean;
+	filters: TagFilter | null;
+	page: number;
+	setPage: Dispatch<SetStateAction<number>>;
+}): {
+	logs: ILog[];
+	handleShowNextLines: () => void;
+	isError: boolean;
+	isFetching: boolean;
+	isDisabledFetch: boolean;
+} => {
+	const [logs, setLogs] = useState<ILog[]>([]);
+
+	const orderByTimestamp = useMemo(() => getOrderByTimestamp(order), [order]);
+
+	const logsMorePageSize = useMemo(() => (page - 1) * LOGS_MORE_PAGE_SIZE, [
+		page,
+	]);
+	const pageSize = useMemo(
+		() => (page <= 1 ? INITIAL_PAGE_SIZE : logsMorePageSize + INITIAL_PAGE_SIZE),
+		[page, logsMorePageSize],
+	);
+	const isDisabledFetch = useMemo(() => logs.length < pageSize, [
+		logs.length,
+		pageSize,
+	]);
+
+	const currentStagedQueryData = useMemo(() => {
+		if (!query || query.builder.queryData.length !== 1) return null;
+
+		return query.builder.queryData[0];
+	}, [query]);
+
+	const initialLogsRequest = useMemo(
+		() =>
+			getRequestData({
+				stagedQueryData: currentStagedQueryData,
+				query,
+				log,
+				orderByTimestamp,
+				page,
+			}),
+		[currentStagedQueryData, page, log, query, orderByTimestamp],
+	);
+
+	const [requestData, setRequestData] = useState<Query | null>(
+		initialLogsRequest,
+	);
+
+	const handleSuccess = useCallback(
+		(data: SuccessResponse<MetricRangePayloadProps, unknown>) => {
+			const currentData = data?.payload.data.newResult.data.result || [];
+
+			if (currentData.length > 0 && currentData[0].list) {
+				const currentLogs: ILog[] = currentData[0].list.map((item) => ({
+					...item.data,
+					timestamp: item.timestamp,
+				}));
+
+				if (order === ORDERBY_FILTERS.ASC) {
+					const reversedCurrentLogs = currentLogs.reverse();
+					setLogs([...reversedCurrentLogs]);
+				} else {
+					setLogs([...currentLogs]);
+				}
+			}
+		},
+		[order],
+	);
+
+	const { isError, isFetching } = useGetExplorerQueryRange(
+		requestData,
+		PANEL_TYPES.LIST,
+		DEFAULT_ENTITY_VERSION,
+		{
+			keepPreviousData: true,
+			enabled: !!requestData,
+			onSuccess: handleSuccess,
+		},
+	);
+
+	const handleShowNextLines = useCallback(() => {
+		const newRequestData = getRequestData({
+			stagedQueryData: currentStagedQueryData,
+			query,
+			log,
+			orderByTimestamp,
+			page: page + 1,
+			pageSize: LOGS_MORE_PAGE_SIZE,
+		});
+
+		setPage((prevPage) => prevPage + 1);
+		setRequestData(newRequestData);
+		// eslint-disable-next-line react-hooks/exhaustive-deps
+	}, [
+		query,
+		page,
+		order,
+		currentStagedQueryData,
+		isDisabledFetch,
+		orderByTimestamp,
+	]);
+
+	useEffect(() => {
+		if (!isEdit) return;
+
+		const newRequestData = getRequestData({
+			stagedQueryData: currentStagedQueryData,
+			query,
+			log,
+			orderByTimestamp,
+			page: 1,
+		});
+
+		setPage(1);
+		setLogs([]);
+		setRequestData(newRequestData);
+		// eslint-disable-next-line react-hooks/exhaustive-deps
+	}, [filters]);
+
+	return {
+		logs,
+		handleShowNextLines,
+		isError,
+		isFetching,
+		isDisabledFetch,
+	};
+};