From 4b79d3b7853cf52e8bbc4d88a785c1f4ea750810 Mon Sep 17 00:00:00 2001 From: Vikrant Gupta Date: Wed, 9 Oct 2024 11:41:38 +0530 Subject: [PATCH] fix: incorrect query being generated from traces page (#6130) --- .../filters/QueryBuilderSearchV2/QueryBuilderSearchV2.tsx | 4 ++-- .../src/container/TraceDetail/SelectedSpanDetails/config.ts | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/frontend/src/container/QueryBuilder/filters/QueryBuilderSearchV2/QueryBuilderSearchV2.tsx b/frontend/src/container/QueryBuilder/filters/QueryBuilderSearchV2/QueryBuilderSearchV2.tsx index 0925c10d97..d07ba7169c 100644 --- a/frontend/src/container/QueryBuilder/filters/QueryBuilderSearchV2/QueryBuilderSearchV2.tsx +++ b/frontend/src/container/QueryBuilder/filters/QueryBuilderSearchV2/QueryBuilderSearchV2.tsx @@ -244,7 +244,7 @@ function QueryBuilderSearchV2( isFetching: isFetchingSuggestions, } = useGetAttributeSuggestions( { - searchText: searchValue.split(' ')[0], + searchText: searchValue?.split(' ')[0], dataSource: query.dataSource, filters: query.filters, }, @@ -691,7 +691,7 @@ function QueryBuilderSearchV2( } } if (currentState === DropdownState.OPERATOR) { - const keyOperator = searchValue.split(' '); + const keyOperator = searchValue?.split(' '); const partialOperator = keyOperator?.[1]; const strippedKey = keyOperator?.[0]; diff --git a/frontend/src/container/TraceDetail/SelectedSpanDetails/config.ts b/frontend/src/container/TraceDetail/SelectedSpanDetails/config.ts index 145b79f2ff..2b6dd6ffea 100644 --- a/frontend/src/container/TraceDetail/SelectedSpanDetails/config.ts +++ b/frontend/src/container/TraceDetail/SelectedSpanDetails/config.ts @@ -1,4 +1,5 @@ import { initialAutocompleteData, OPERATORS } from 'constants/queryBuilder'; +import { getOperatorValue } from 'container/QueryBuilder/filters/QueryBuilderSearch/utils'; import getStep from 'lib/getStep'; import { BaseAutocompleteData, @@ -27,7 +28,8 @@ export const getTraceToLogsQuery = ( items: [ { id: uuid(), - op: OPERATORS.IN, + // for generating query we use in instead of IN + op: getOperatorValue(OPERATORS.IN), value: traceId, key, },