GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-14 14:06:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: update apdex query to use placeholder parameters (#3409)

Browse Source
This commit is contained in:
Srikanth Chekuri 2023-08-24 11:09:51 +05:30 committed by GitHub
parent 48538e6b96
commit 4d14416a08
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/query-service/dao/sqlite/apdex.go
View File

@ -4,6 +4,7 @@ import (
"context" "context"
"fmt" "fmt"
"github.com/jmoiron/sqlx"
"go.signoz.io/signoz/pkg/query-service/model" "go.signoz.io/signoz/pkg/query-service/model"
) )
@ -11,19 +12,16 @@ const defaultApdexThreshold = 0.5
func (mds *ModelDaoSqlite) GetApdexSettings(ctx context.Context, services []string) ([]model.ApdexSettings, *model.ApiError) { func (mds *ModelDaoSqlite) GetApdexSettings(ctx context.Context, services []string) ([]model.ApdexSettings, *model.ApiError) {
var apdexSettings []model.ApdexSettings var apdexSettings []model.ApdexSettings
var serviceName string
for i, service := range services { query, args, err := sqlx.In("SELECT * FROM apdex_settings WHERE service_name IN (?)", services)
if i == 0 { if err != nil {
serviceName = fmt.Sprintf("'%s'", service) return nil, &model.ApiError{
} else { Err: err,
serviceName = fmt.Sprintf("%s, '%s'", serviceName, service)
} }
} }
query = mds.db.Rebind(query)
query := fmt.Sprintf("SELECT * FROM apdex_settings WHERE service_name IN (%s)", serviceName) err = mds.db.Select(&apdexSettings, query, args...)
err := mds.db.Select(&apdexSettings, query)
if err != nil { if err != nil {
return nil, &model.ApiError{ return nil, &model.ApiError{
Err: err, Err: err,