GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-14 21:57:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: do not move to next step if env not selected in onboarding (#4784)

Browse Source
This commit is contained in:
Vikrant Gupta 2024-04-01 13:56:59 +05:30 committed by GitHub
parent 00d74bfebb
commit 51abe71421
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/src/container/OnboardingContainer/common/ModuleStepsContainer/ModuleStepsContainer.tsx
View File

@ -16,7 +16,7 @@ import { DataSourceType } from 'container/OnboardingContainer/Steps/DataSource/D
import { hasFrameworks } from 'container/OnboardingContainer/utils/dataSourceUtils'; import { hasFrameworks } from 'container/OnboardingContainer/utils/dataSourceUtils';
import useAnalytics from 'hooks/analytics/useAnalytics'; import useAnalytics from 'hooks/analytics/useAnalytics';
import history from 'lib/history'; import history from 'lib/history';
import { isEmpty } from 'lodash-es'; import { isEmpty, isNull } from 'lodash-es';
import { useState } from 'react'; import { useState } from 'react';
import { useOnboardingContext } from '../../context/OnboardingContext'; import { useOnboardingContext } from '../../context/OnboardingContext';
@ -91,7 +91,10 @@ export default function ModuleStepsContainer({
name: selectedDataSourceName = '', name: selectedDataSourceName = '',
} = selectedDataSource as DataSourceType; } = selectedDataSource as DataSourceType;
if (step.id === environmentDetailsStep && selectedEnvironment === '') { if (
step.id === environmentDetailsStep &&
(selectedEnvironment === '' || isNull(selectedEnvironment))
) {
updateErrorDetails('Please select environment'); updateErrorDetails('Please select environment');
return false; return false;
} }