From 5ad367a0fcdfe5ac7f79e890c365369f68666aab Mon Sep 17 00:00:00 2001 From: Palash Gupta Date: Wed, 26 Apr 2023 13:53:53 +0530 Subject: [PATCH] fix: dashboard variable is fixed (#2633) --- .../DashboardVariablesSelection/VariableItem.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/frontend/src/container/NewDashboard/DashboardVariablesSelection/VariableItem.tsx b/frontend/src/container/NewDashboard/DashboardVariablesSelection/VariableItem.tsx index 8841d10d0a..0aa6e61b90 100644 --- a/frontend/src/container/NewDashboard/DashboardVariablesSelection/VariableItem.tsx +++ b/frontend/src/container/NewDashboard/DashboardVariablesSelection/VariableItem.tsx @@ -5,7 +5,7 @@ import query from 'api/dashboard/variables/query'; import { commaValuesParser } from 'lib/dashbaordVariables/customCommaValuesParser'; import sortValues from 'lib/dashbaordVariables/sortVariableValues'; import { map } from 'lodash-es'; -import React, { useCallback, useEffect, useState } from 'react'; +import React, { memo, useCallback, useEffect, useState } from 'react'; import { IDashboardVariable } from 'types/api/dashboard/getAll'; import { variablePropsToPayloadVariables } from '../utils'; @@ -130,7 +130,7 @@ function VariableItem({ useEffect(() => { getOptions(); // eslint-disable-next-line react-hooks/exhaustive-deps - }, []); + }, [variableData, existingVariables]); const handleChange = (value: string | string[]): void => { if ( @@ -201,4 +201,4 @@ function VariableItem({ ); } -export default VariableItem; +export default memo(VariableItem);