GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-16 13:25:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: improve error message readability (#5628)

Browse Source
This commit is contained in:
Srikanth Chekuri 2024-09-13 18:01:37 +05:30 committed by GitHub
parent 39f9fc6900
commit 5b22490d6d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/query-service/app/clickhouseReader/reader.go
View File

@ -4997,7 +4997,7 @@ func (r *ClickHouseReader) GetTimeSeriesResultV3(ctx context.Context, query stri
if err != nil { if err != nil {
zap.L().Error("error while reading time series result", zap.Error(err)) zap.L().Error("error while reading time series result", zap.Error(err))
return nil, err return nil, errors.New(err.Error())
} }
defer rows.Close() defer rows.Close()
@ -5044,7 +5044,7 @@ func (r *ClickHouseReader) GetListResultV3(ctx context.Context, query string) ([
if err != nil { if err != nil {
zap.L().Error("error while reading time series result", zap.Error(err)) zap.L().Error("error while reading time series result", zap.Error(err))
return nil, err return nil, errors.New(err.Error())
} }
defer rows.Close() defer rows.Close()

16
pkg/query-service/app/http_handler.go
View File

@ -3716,8 +3716,12 @@ func (aH *APIHandler) queryRangeV3(ctx context.Context, queryRangeParams *v3.Que
result, errQuriesByName, err = aH.querier.QueryRange(ctx, queryRangeParams) result, errQuriesByName, err = aH.querier.QueryRange(ctx, queryRangeParams)
if err != nil { if err != nil {
apiErrObj := &model.ApiError{Typ: model.ErrorBadData, Err: err} queryErrors := map[string]string{}
RespondError(w, apiErrObj, errQuriesByName) for name, err := range errQuriesByName {
queryErrors[fmt.Sprintf("Query-%s", name)] = err.Error()
}
apiErrObj := &model.ApiError{Typ: model.ErrorInternal, Err: err}
RespondError(w, apiErrObj, queryErrors)
return return
} }
@ -4160,8 +4164,12 @@ func (aH *APIHandler) queryRangeV4(ctx context.Context, queryRangeParams *v3.Que
result, errQuriesByName, err = aH.querierV2.QueryRange(ctx, queryRangeParams) result, errQuriesByName, err = aH.querierV2.QueryRange(ctx, queryRangeParams)
if err != nil { if err != nil {
apiErrObj := &model.ApiError{Typ: model.ErrorBadData, Err: err} queryErrors := map[string]string{}
RespondError(w, apiErrObj, errQuriesByName) for name, err := range errQuriesByName {
queryErrors[fmt.Sprintf("Query-%s", name)] = err.Error()
}
apiErrObj := &model.ApiError{Typ: model.ErrorInternal, Err: err}
RespondError(w, apiErrObj, queryErrors)
return return
} }

2
pkg/query-service/app/querier/querier.go
View File

@ -566,7 +566,7 @@ func (q *querier) runBuilderListQueries(ctx context.Context, params *v3.QueryRan
rowList, err := q.reader.GetListResultV3(ctx, query) rowList, err := q.reader.GetListResultV3(ctx, query)
if err != nil { if err != nil {
ch <- channelResult{Err: fmt.Errorf("error in query-%s: %v", name, err), Name: name, Query: query} ch <- channelResult{Err: err, Name: name, Query: query}
return return
} }
ch <- channelResult{List: rowList, Name: name, Query: query} ch <- channelResult{List: rowList, Name: name, Query: query}

2
pkg/query-service/app/querier/v2/querier.go
View File

@ -574,7 +574,7 @@ func (q *querier) runBuilderListQueries(ctx context.Context, params *v3.QueryRan
rowList, err := q.reader.GetListResultV3(ctx, query) rowList, err := q.reader.GetListResultV3(ctx, query)
if err != nil { if err != nil {
ch <- channelResult{Err: fmt.Errorf("error in query-%s: %v", name, err), Name: name, Query: query} ch <- channelResult{Err: err, Name: name, Query: query}
return return
} }
ch <- channelResult{List: rowList, Name: name, Query: query} ch <- channelResult{List: rowList, Name: name, Query: query}