From 9bcdb2ede662140ccbbf5c254e1343e1ab450b41 Mon Sep 17 00:00:00 2001 From: dhrubesh Date: Mon, 10 May 2021 00:01:50 +0530 Subject: [PATCH 1/2] removes set alert --- frontend/src/modules/Metrics/ErrorRateChart.tsx | 2 +- frontend/src/modules/Metrics/LatencyLineChart.tsx | 2 +- frontend/src/modules/Metrics/RequestRateChart.tsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/frontend/src/modules/Metrics/ErrorRateChart.tsx b/frontend/src/modules/Metrics/ErrorRateChart.tsx index 116b29192c..8740844128 100644 --- a/frontend/src/modules/Metrics/ErrorRateChart.tsx +++ b/frontend/src/modules/Metrics/ErrorRateChart.tsx @@ -188,7 +188,7 @@ class ErrorRateChart extends React.Component { ycoordinate={this.state.ycoordinate} > View Traces - Set Alerts + {/* Set Alerts */} ); } else return null; diff --git a/frontend/src/modules/Metrics/LatencyLineChart.tsx b/frontend/src/modules/Metrics/LatencyLineChart.tsx index 2a9c1bebc8..d4d770c020 100644 --- a/frontend/src/modules/Metrics/LatencyLineChart.tsx +++ b/frontend/src/modules/Metrics/LatencyLineChart.tsx @@ -193,7 +193,7 @@ class LatencyLineChart extends React.Component { > View Traces - Set Alerts + {/* Set Alerts */} ); } else return null; diff --git a/frontend/src/modules/Metrics/RequestRateChart.tsx b/frontend/src/modules/Metrics/RequestRateChart.tsx index 81c74c0bb5..c82ee1bd6c 100644 --- a/frontend/src/modules/Metrics/RequestRateChart.tsx +++ b/frontend/src/modules/Metrics/RequestRateChart.tsx @@ -177,7 +177,7 @@ class RequestRateChart extends React.Component { ycoordinate={this.state.ycoordinate} > View Traces - Set Alerts + {/* Set Alerts */} ); } else return null; From e9c03c4d8581af832f384d970d68aef21f760861 Mon Sep 17 00:00:00 2001 From: dhrubesh Date: Mon, 10 May 2021 00:05:49 +0530 Subject: [PATCH 2/2] p90->p95 --- frontend/src/modules/Metrics/LatencyLineChart.tsx | 4 ++-- frontend/src/store/actions/metrics.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/frontend/src/modules/Metrics/LatencyLineChart.tsx b/frontend/src/modules/Metrics/LatencyLineChart.tsx index d4d770c020..daf63b43ac 100644 --- a/frontend/src/modules/Metrics/LatencyLineChart.tsx +++ b/frontend/src/modules/Metrics/LatencyLineChart.tsx @@ -218,8 +218,8 @@ class LatencyLineChart extends React.Component { borderWidth: 2, }, { - label: "p90 Latency", - data: ndata.map((s) => s.p90 / 1000000), //converting latency from nano sec to ms + label: "p95 Latency", + data: ndata.map((s) => s.p95 / 1000000), //converting latency from nano sec to ms pointRadius: 0.5, borderColor: "rgba(227, 74, 51, 1.0)", borderWidth: 2, diff --git a/frontend/src/store/actions/metrics.ts b/frontend/src/store/actions/metrics.ts index bd35b2415f..2643f9028f 100644 --- a/frontend/src/store/actions/metrics.ts +++ b/frontend/src/store/actions/metrics.ts @@ -19,7 +19,7 @@ export interface servicesListItem { export interface metricItem { timestamp: number; p50: number; - p90: number; + p95: number; p99: number; numCalls: number; callRate: number;