GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-16 06:05:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: remove disabled in case of dashboard locked (#4709)

Browse Source
This commit is contained in:
Vikrant Gupta 2024-03-15 12:28:03 +05:30 committed by GitHub
parent 0365fa5421
commit 60946b5e9d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 71 additions and 80 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
frontend/src/container/NewDashboard/DashboardVariablesSelection/VariableItem.tsx
View File

@ -2,14 +2,13 @@ import './DashboardVariableSelection.styles.scss';
import { orange } from '@ant-design/colors'; import { orange } from '@ant-design/colors';
import { WarningOutlined } from '@ant-design/icons'; import { WarningOutlined } from '@ant-design/icons';
import { Input, Popover, Select, Tooltip, Typography } from 'antd'; import { Input, Popover, Select, Typography } from 'antd';
import dashboardVariablesQuery from 'api/dashboard/variables/dashboardVariablesQuery'; import dashboardVariablesQuery from 'api/dashboard/variables/dashboardVariablesQuery';
import { REACT_QUERY_KEY } from 'constants/reactQueryKeys'; import { REACT_QUERY_KEY } from 'constants/reactQueryKeys';
import { commaValuesParser } from 'lib/dashbaordVariables/customCommaValuesParser'; import { commaValuesParser } from 'lib/dashbaordVariables/customCommaValuesParser';
import sortValues from 'lib/dashbaordVariables/sortVariableValues'; import sortValues from 'lib/dashbaordVariables/sortVariableValues';
import { debounce } from 'lodash-es'; import { debounce } from 'lodash-es';
import map from 'lodash-es/map'; import map from 'lodash-es/map';
import { useDashboard } from 'providers/Dashboard/Dashboard';
import { memo, useEffect, useMemo, useState } from 'react'; import { memo, useEffect, useMemo, useState } from 'react';
import { useQuery } from 'react-query'; import { useQuery } from 'react-query';
import { IDashboardVariable } from 'types/api/dashboard/getAll'; import { IDashboardVariable } from 'types/api/dashboard/getAll';
@ -52,7 +51,6 @@ function VariableItem({
onValueUpdate, onValueUpdate,
lastUpdatedVar, lastUpdatedVar,
}: VariableItemProps): JSX.Element { }: VariableItemProps): JSX.Element {
const { isDashboardLocked } = useDashboard();
const [optionsData, setOptionsData] = useState<(string | number | boolean)[]>( const [optionsData, setOptionsData] = useState<(string | number | boolean)[]>(
[], [],
); );
@ -222,10 +220,6 @@ function VariableItem({
}, [variableData.type, variableData.customValue]); }, [variableData.type, variableData.customValue]);
return ( return (
<Tooltip
placement="top"
title={isDashboardLocked ? 'Dashboard is locked' : ''}
>
<VariableContainer className="variable-item"> <VariableContainer className="variable-item">
<Typography.Text className="variable-name" ellipsis> <Typography.Text className="variable-name" ellipsis>
${variableData.name} ${variableData.name}
@ -234,7 +228,6 @@ function VariableItem({
{variableData.type === 'TEXTBOX' ? ( {variableData.type === 'TEXTBOX' ? (
<Input <Input
placeholder="Enter value" placeholder="Enter value"
disabled={isDashboardLocked}
bordered={false} bordered={false}
key={variableData.selectedValue?.toString()} key={variableData.selectedValue?.toString()}
defaultValue={variableData.selectedValue?.toString()} defaultValue={variableData.selectedValue?.toString()}
@ -267,7 +260,6 @@ function VariableItem({
showSearch showSearch
data-testid="variable-select" data-testid="variable-select"
className="variable-select" className="variable-select"
disabled={isDashboardLocked}
getPopupContainer={popupContainer} getPopupContainer={popupContainer}
> >
{enableSelectAll && ( {enableSelectAll && (
@ -299,7 +291,6 @@ function VariableItem({
)} )}
</VariableValue> </VariableValue>
</VariableContainer> </VariableContainer>
</Tooltip>
); );
} }