fix: add support for count aggregate attribute (#2584)

This commit is contained in:
Vishal Sharma 2023-04-18 16:38:52 +05:30 committed by GitHub
parent 51f1d0fd05
commit 60b78e94d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -3806,7 +3806,9 @@ func (r *ClickHouseReader) GetLogAggregateAttributes(ctx context.Context, req *v
where := ""
switch req.Operator {
case v3.AggregateOperatorCountDistinct:
case
v3.AggregateOperatorCountDistinct,
v3.AggregateOpeatorCount:
where = "tagKey ILIKE $1"
case
v3.AggregateOperatorRateSum,
@ -3829,7 +3831,6 @@ func (r *ClickHouseReader) GetLogAggregateAttributes(ctx context.Context, req *v
v3.AggregateOperatorMax:
where = "tagKey ILIKE $1 AND (tagDataType='int64' or tagDataType='float64')"
case
v3.AggregateOpeatorCount,
v3.AggregateOperatorNoOp:
return &v3.AggregateAttributeResponse{}, nil
default:
@ -4228,7 +4229,9 @@ func (r *ClickHouseReader) GetTraceAggregateAttributes(ctx context.Context, req
var response v3.AggregateAttributeResponse
where := ""
switch req.Operator {
case v3.AggregateOperatorCountDistinct:
case
v3.AggregateOperatorCountDistinct,
v3.AggregateOpeatorCount:
where = "tagKey ILIKE $1"
case
v3.AggregateOperatorRateSum,
@ -4251,7 +4254,6 @@ func (r *ClickHouseReader) GetTraceAggregateAttributes(ctx context.Context, req
v3.AggregateOperatorMax:
where = "tagKey ILIKE $1 AND dataType='float64'"
case
v3.AggregateOpeatorCount,
v3.AggregateOperatorNoOp:
return &v3.AggregateAttributeResponse{}, nil
default: