From 629c54d3f91dedf16509cad1790e3ffa55f08f9c Mon Sep 17 00:00:00 2001 From: Srikanth Chekuri Date: Tue, 29 Apr 2025 20:31:31 +0530 Subject: [PATCH] fix: nil pointer error on failed to create rule (#7767) --- ee/query-service/rules/manager.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ee/query-service/rules/manager.go b/ee/query-service/rules/manager.go index cb67a5ab4b..e05146348a 100644 --- a/ee/query-service/rules/manager.go +++ b/ee/query-service/rules/manager.go @@ -127,7 +127,7 @@ func TestNotification(opts baserules.PrepareTestRuleOptions) (int, *basemodel.Ap ) if err != nil { - zap.L().Error("failed to prepare a new threshold rule for test", zap.String("name", rule.Name()), zap.Error(err)) + zap.L().Error("failed to prepare a new threshold rule for test", zap.String("name", alertname), zap.Error(err)) return 0, basemodel.BadRequest(err) } @@ -146,7 +146,7 @@ func TestNotification(opts baserules.PrepareTestRuleOptions) (int, *basemodel.Ap ) if err != nil { - zap.L().Error("failed to prepare a new promql rule for test", zap.String("name", rule.Name()), zap.Error(err)) + zap.L().Error("failed to prepare a new promql rule for test", zap.String("name", alertname), zap.Error(err)) return 0, basemodel.BadRequest(err) } } else if parsedRule.RuleType == ruletypes.RuleTypeAnomaly { @@ -161,7 +161,7 @@ func TestNotification(opts baserules.PrepareTestRuleOptions) (int, *basemodel.Ap baserules.WithSQLStore(opts.SQLStore), ) if err != nil { - zap.L().Error("failed to prepare a new anomaly rule for test", zap.String("name", rule.Name()), zap.Error(err)) + zap.L().Error("failed to prepare a new anomaly rule for test", zap.String("name", alertname), zap.Error(err)) return 0, basemodel.BadRequest(err) } } else {