From 62ad8433bf44ac72871f47a7bf008cc8a78e1840 Mon Sep 17 00:00:00 2001
From: dhrubesh <dhrubesh97@gmail.com>
Date: Sun, 2 May 2021 20:02:44 +0530
Subject: [PATCH] adds service name in the trace when visiting from error

---
 frontend/src/modules/Traces/TraceFilter.tsx | 30 ++++++++++++++++-----
 1 file changed, 23 insertions(+), 7 deletions(-)

diff --git a/frontend/src/modules/Traces/TraceFilter.tsx b/frontend/src/modules/Traces/TraceFilter.tsx
index 20baf744b9..c1e04c8f89 100644
--- a/frontend/src/modules/Traces/TraceFilter.tsx
+++ b/frontend/src/modules/Traces/TraceFilter.tsx
@@ -62,6 +62,10 @@ const _TraceFilter = (props: TraceFilterProps) => {
 				setServiceList(response.data);
 			})
 			.then(() => {
+				/*
+				Todo
+				revisit this flow post refactoring store
+				*/
 				const operationName = urlParams.get(METRICS_PAGE_QUERY_PARAM.operation);
 				const serviceName = urlParams.get(METRICS_PAGE_QUERY_PARAM.service);
 				const errorTag = urlParams.get(METRICS_PAGE_QUERY_PARAM.error);
@@ -72,6 +76,18 @@ const _TraceFilter = (props: TraceFilterProps) => {
 						service: serviceName,
 					});
 					populateData(serviceName);
+				} else if (serviceName && errorTag) {
+					props.updateTraceFilters({
+						...props.traceFilters,
+						service: serviceName,
+						tags: [
+							{
+								key: METRICS_PAGE_QUERY_PARAM.error,
+								value: errorTag,
+								operator: "EQUAL",
+							},
+						],
+					});
 				} else {
 					if (operationName) {
 						handleChangeOperation(operationName);
@@ -79,13 +95,13 @@ const _TraceFilter = (props: TraceFilterProps) => {
 					if (serviceName) {
 						handleChangeService(serviceName);
 					}
-				}
-				if (errorTag) {
-					onTagFormSubmit({
-						tag_key: METRICS_PAGE_QUERY_PARAM.error,
-						tag_value: errorTag,
-						operator: "EQUAL",
-					});
+					if (errorTag) {
+						onTagFormSubmit({
+							tag_key: METRICS_PAGE_QUERY_PARAM.error,
+							tag_value: errorTag,
+							operator: "EQUAL",
+						});
+					}
 				}
 			});
 	}, []);