From bbffac1603caec721d4ff19b5bfbbd09a7a947a4 Mon Sep 17 00:00:00 2001
From: Chintan Sudani <46838508+techchintan@users.noreply.github.com>
Date: Tue, 25 Apr 2023 11:02:10 +0530
Subject: [PATCH] fix: Only positive integer values should be allowed for limit
 (#2619)

* fix: only positive number should accept on limit

* fix: suggested changes
---
 .../filters/LimitFilter/LimitFilter.tsx        | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/frontend/src/container/QueryBuilder/filters/LimitFilter/LimitFilter.tsx b/frontend/src/container/QueryBuilder/filters/LimitFilter/LimitFilter.tsx
index 066f22911d..d45bac0837 100644
--- a/frontend/src/container/QueryBuilder/filters/LimitFilter/LimitFilter.tsx
+++ b/frontend/src/container/QueryBuilder/filters/LimitFilter/LimitFilter.tsx
@@ -5,8 +5,19 @@ import { IBuilderQueryForm } from 'types/api/queryBuilder/queryBuilderData';
 import { selectStyle } from '../QueryBuilderSearch/config';
 
 function LimitFilter({ onChange, query }: LimitFilterProps): JSX.Element {
-	const onChangeHandler = (value: number | null): void => {
-		onChange(value);
+	const handleKeyDown = (event: {
+		keyCode: number;
+		which: number;
+		preventDefault: () => void;
+	}): void => {
+		const keyCode = event.keyCode || event.which;
+		const isBackspace = keyCode === 8;
+		const isNumeric =
+			(keyCode >= 48 && keyCode <= 57) || (keyCode >= 96 && keyCode <= 105);
+
+		if (!isNumeric && !isBackspace) {
+			event.preventDefault();
+		}
 	};
 
 	return (
@@ -15,7 +26,8 @@ function LimitFilter({ onChange, query }: LimitFilterProps): JSX.Element {
 			type="number"
 			disabled={!query.aggregateAttribute.key}
 			style={selectStyle}
-			onChange={onChangeHandler}
+			onChange={onChange}
+			onKeyDown={handleKeyDown}
 		/>
 	);
 }