From 6a4aa9a956b4b6536f60e7b47cb75d17bcdc5f55 Mon Sep 17 00:00:00 2001
From: Yunus M <myounis.ar@live.com>
Date: Thu, 4 Apr 2024 11:05:58 +0530
Subject: [PATCH] QB - Logs - Enable TimeShift function (#4792)

* feat: qb - logs - enable time shift function

* feat: qb - logs - enable time shift function

* feat: show functions for logs in v3 version too
---
 .../src/constants/queryFunctionOptions.ts     |  8 +++++-
 .../container/FormAlertRules/QuerySection.tsx |  5 ++--
 .../QBEntityOptions.styles.scss               |  1 +
 .../QBEntityOptions/QBEntityOptions.tsx       |  7 ++++-
 .../QueryBuilder/components/Query/Query.tsx   |  6 ++++-
 .../components/QueryFunctions/Function.tsx    | 19 +++++++++++---
 .../QueryFunctions/QueryFunctions.tsx         | 26 ++++++++++++++++---
 .../queryBuilder/useQueryBuilderOperations.ts |  7 ++++-
 8 files changed, 66 insertions(+), 13 deletions(-)

diff --git a/frontend/src/constants/queryFunctionOptions.ts b/frontend/src/constants/queryFunctionOptions.ts
index b79f673c46..4aa6332d67 100644
--- a/frontend/src/constants/queryFunctionOptions.ts
+++ b/frontend/src/constants/queryFunctionOptions.ts
@@ -2,7 +2,7 @@
 import { QueryFunctionsTypes } from 'types/common/queryBuilder';
 import { SelectOption } from 'types/common/select';
 
-export const queryFunctionOptions: SelectOption<string, string>[] = [
+export const metricQueryFunctionOptions: SelectOption<string, string>[] = [
 	{
 		value: QueryFunctionsTypes.CUTOFF_MIN,
 		label: 'Cut Off Min',
@@ -65,6 +65,12 @@ export const queryFunctionOptions: SelectOption<string, string>[] = [
 	},
 ];
 
+export const logsQueryFunctionOptions: SelectOption<string, string>[] = [
+	{
+		value: QueryFunctionsTypes.TIME_SHIFT,
+		label: 'Time Shift',
+	},
+];
 interface QueryFunctionConfigType {
 	[key: string]: {
 		showInput: boolean;
diff --git a/frontend/src/container/FormAlertRules/QuerySection.tsx b/frontend/src/container/FormAlertRules/QuerySection.tsx
index 1604cdb929..406a757eda 100644
--- a/frontend/src/container/FormAlertRules/QuerySection.tsx
+++ b/frontend/src/container/FormAlertRules/QuerySection.tsx
@@ -56,8 +56,9 @@ function QuerySection({
 				initialDataSource: ALERTS_DATA_SOURCE_MAP[alertType],
 			}}
 			showFunctions={
-				alertType === AlertTypes.METRICS_BASED_ALERT &&
-				alertDef.version === ENTITY_VERSION_V4
+				(alertType === AlertTypes.METRICS_BASED_ALERT &&
+					alertDef.version === ENTITY_VERSION_V4) ||
+				alertType === AlertTypes.LOGS_BASED_ALERT
 			}
 			version={alertDef.version || 'v3'}
 		/>
diff --git a/frontend/src/container/QueryBuilder/components/QBEntityOptions/QBEntityOptions.styles.scss b/frontend/src/container/QueryBuilder/components/QBEntityOptions/QBEntityOptions.styles.scss
index 3bafb59879..f0c7565d29 100644
--- a/frontend/src/container/QueryBuilder/components/QBEntityOptions/QBEntityOptions.styles.scss
+++ b/frontend/src/container/QueryBuilder/components/QBEntityOptions/QBEntityOptions.styles.scss
@@ -77,6 +77,7 @@
 	.qb-entity-options {
 		.options {
 			border-color: var(--bg-vanilla-300);
+			box-shadow: none;
 
 			.periscope-btn {
 				border-color: var(--bg-vanilla-300);
diff --git a/frontend/src/container/QueryBuilder/components/QBEntityOptions/QBEntityOptions.tsx b/frontend/src/container/QueryBuilder/components/QBEntityOptions/QBEntityOptions.tsx
index 8730506a88..fd8e860508 100644
--- a/frontend/src/container/QueryBuilder/components/QBEntityOptions/QBEntityOptions.tsx
+++ b/frontend/src/container/QueryBuilder/components/QBEntityOptions/QBEntityOptions.tsx
@@ -17,6 +17,7 @@ import {
 	IBuilderQuery,
 	QueryFunctionProps,
 } from 'types/api/queryBuilder/queryBuilderData';
+import { DataSource } from 'types/common/queryBuilder';
 
 import QueryFunctions from '../QueryFunctions/QueryFunctions';
 
@@ -57,6 +58,8 @@ export default function QBEntityOptions({
 		}
 	};
 
+	const isLogsDataSource = query?.dataSource === DataSource.LOGS;
+
 	return (
 		<Col span={24}>
 			<div className="qb-entity-options">
@@ -97,12 +100,14 @@ export default function QBEntityOptions({
 							</Button>
 
 							{showFunctions &&
-								isMetricsDataSource &&
+								(isMetricsDataSource || isLogsDataSource) &&
 								query &&
 								onQueryFunctionsUpdates && (
 									<QueryFunctions
+										query={query}
 										queryFunctions={query.functions}
 										onChange={onQueryFunctionsUpdates}
+										maxFunctions={isLogsDataSource ? 1 : 3}
 									/>
 								)}
 						</Button.Group>
diff --git a/frontend/src/container/QueryBuilder/components/Query/Query.tsx b/frontend/src/container/QueryBuilder/components/Query/Query.tsx
index 1bb761fde7..fb8b0e1561 100644
--- a/frontend/src/container/QueryBuilder/components/Query/Query.tsx
+++ b/frontend/src/container/QueryBuilder/components/Query/Query.tsx
@@ -36,6 +36,7 @@ import {
 } from 'react';
 import { useLocation } from 'react-use';
 import { IBuilderQuery } from 'types/api/queryBuilder/queryBuilderData';
+import { DataSource } from 'types/common/queryBuilder';
 import { transformToUpperCase } from 'utils/transformToUpperCase';
 
 import QBEntityOptions from '../QBEntityOptions/QBEntityOptions';
@@ -324,7 +325,10 @@ export const Query = memo(function Query({
 			<QBEntityOptions
 				isMetricsDataSource={isMetricsDataSource}
 				showFunctions={
-					(version && version === ENTITY_VERSION_V4) || showFunctions || false
+					(version && version === ENTITY_VERSION_V4) ||
+					query.dataSource === DataSource.LOGS ||
+					showFunctions ||
+					false
 				}
 				isCollapsed={isCollapse}
 				entityType="query"
diff --git a/frontend/src/container/QueryBuilder/components/QueryFunctions/Function.tsx b/frontend/src/container/QueryBuilder/components/QueryFunctions/Function.tsx
index 1374c2bb1a..a341d5db55 100644
--- a/frontend/src/container/QueryBuilder/components/QueryFunctions/Function.tsx
+++ b/frontend/src/container/QueryBuilder/components/QueryFunctions/Function.tsx
@@ -2,15 +2,21 @@
 import { Button, Flex, Input, Select } from 'antd';
 import cx from 'classnames';
 import {
-	queryFunctionOptions,
+	logsQueryFunctionOptions,
+	metricQueryFunctionOptions,
 	queryFunctionsTypesConfig,
 } from 'constants/queryFunctionOptions';
 import { useIsDarkMode } from 'hooks/useDarkMode';
 import { debounce, isNil } from 'lodash-es';
 import { X } from 'lucide-react';
-import { QueryFunctionProps } from 'types/api/queryBuilder/queryBuilderData';
+import {
+	IBuilderQuery,
+	QueryFunctionProps,
+} from 'types/api/queryBuilder/queryBuilderData';
+import { DataSource } from 'types/common/queryBuilder';
 
 interface FunctionProps {
+	query: IBuilderQuery;
 	funcData: QueryFunctionProps;
 	index: any;
 	handleUpdateFunctionArgs: any;
@@ -19,6 +25,7 @@ interface FunctionProps {
 }
 
 export default function Function({
+	query,
 	funcData,
 	index,
 	handleUpdateFunctionArgs,
@@ -44,6 +51,12 @@ export default function Function({
 		500,
 	);
 
+	// update the logic when we start supporting functions for traces
+	const functionOptions =
+		query.dataSource === DataSource.LOGS
+			? logsQueryFunctionOptions
+			: metricQueryFunctionOptions;
+
 	return (
 		<Flex className="query-function">
 			<Select
@@ -62,7 +75,7 @@ export default function Function({
 					boxShadow: `4px 10px 16px 2px rgba(0, 0, 0, 0.20)`,
 				}}
 				placement="bottomRight"
-				options={queryFunctionOptions}
+				options={functionOptions}
 			/>
 
 			{showInput && (
diff --git a/frontend/src/container/QueryBuilder/components/QueryFunctions/QueryFunctions.tsx b/frontend/src/container/QueryBuilder/components/QueryFunctions/QueryFunctions.tsx
index 68c2701982..7dfdd99c9c 100644
--- a/frontend/src/container/QueryBuilder/components/QueryFunctions/QueryFunctions.tsx
+++ b/frontend/src/container/QueryBuilder/components/QueryFunctions/QueryFunctions.tsx
@@ -6,19 +6,29 @@ import { useIsDarkMode } from 'hooks/useDarkMode';
 import { cloneDeep, pullAt } from 'lodash-es';
 import { Plus } from 'lucide-react';
 import { useState } from 'react';
-import { QueryFunctionProps } from 'types/api/queryBuilder/queryBuilderData';
-import { QueryFunctionsTypes } from 'types/common/queryBuilder';
+import {
+	IBuilderQuery,
+	QueryFunctionProps,
+} from 'types/api/queryBuilder/queryBuilderData';
+import { DataSource, QueryFunctionsTypes } from 'types/common/queryBuilder';
 
 import Function from './Function';
 
-const defaultFunctionStruct: QueryFunctionProps = {
+const defaultMetricFunctionStruct: QueryFunctionProps = {
 	name: QueryFunctionsTypes.CUTOFF_MIN,
 	args: [],
 };
 
+const defaultLogFunctionStruct: QueryFunctionProps = {
+	name: QueryFunctionsTypes.TIME_SHIFT,
+	args: [],
+};
+
 interface QueryFunctionsProps {
+	query: IBuilderQuery;
 	queryFunctions: QueryFunctionProps[];
 	onChange: (functions: QueryFunctionProps[]) => void;
+	maxFunctions: number;
 }
 
 // SVG component
@@ -71,8 +81,10 @@ function FunctionIcon({
 }
 
 export default function QueryFunctions({
+	query,
 	queryFunctions,
 	onChange,
+	maxFunctions = 3,
 }: QueryFunctionsProps): JSX.Element {
 	const [functions, setFunctions] = useState<QueryFunctionProps[]>(
 		queryFunctions,
@@ -81,6 +93,11 @@ export default function QueryFunctions({
 	const isDarkMode = useIsDarkMode();
 
 	const handleAddNewFunction = (): void => {
+		const defaultFunctionStruct =
+			query.dataSource === DataSource.LOGS
+				? defaultLogFunctionStruct
+				: defaultMetricFunctionStruct;
+
 		const updatedFunctionsArr = [
 			...functions,
 			{
@@ -149,6 +166,7 @@ export default function QueryFunctions({
 			<div className="query-functions-list">
 				{functions.map((func, index) => (
 					<Function
+						query={query}
 						funcData={func}
 						index={index}
 						// eslint-disable-next-line react/no-array-index-key
@@ -170,7 +188,7 @@ export default function QueryFunctions({
 			>
 				<Button
 					className="periscope-btn add-function-btn"
-					disabled={functions && functions.length >= 3}
+					disabled={functions && functions.length >= maxFunctions}
 					onClick={handleAddNewFunction}
 				>
 					<Plus size={14} color={!isDarkMode ? '#0B0C0E' : 'white'} />
diff --git a/frontend/src/hooks/queryBuilder/useQueryBuilderOperations.ts b/frontend/src/hooks/queryBuilder/useQueryBuilderOperations.ts
index 7766122a45..8b9549ba04 100644
--- a/frontend/src/hooks/queryBuilder/useQueryBuilderOperations.ts
+++ b/frontend/src/hooks/queryBuilder/useQueryBuilderOperations.ts
@@ -294,7 +294,10 @@ export const useQueryOperations: UseQueryOperations = ({
 				...query,
 			};
 
-			if (newQuery.dataSource === DataSource.METRICS) {
+			if (
+				newQuery.dataSource === DataSource.METRICS ||
+				newQuery.dataSource === DataSource.LOGS
+			) {
 				newQuery.functions = functions;
 			}
 
@@ -304,6 +307,7 @@ export const useQueryOperations: UseQueryOperations = ({
 	);
 
 	const isMetricsDataSource = query.dataSource === DataSource.METRICS;
+	const isLogsDataSource = query.dataSource === DataSource.LOGS;
 
 	const isTracePanelType = panelType === PANEL_TYPES.TRACE;
 
@@ -346,6 +350,7 @@ export const useQueryOperations: UseQueryOperations = ({
 	return {
 		isTracePanelType,
 		isMetricsDataSource,
+		isLogsDataSource,
 		operators,
 		spaceAggregationOptions,
 		listOfAdditionalFilters,