diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 1d8d4e7b70..ba92f9f28f 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -8,6 +8,13 @@ on: - release/v* jobs: + check-no-ee-references: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - name: Run check + run: make check-no-ee-references + build-frontend: runs-on: ubuntu-latest steps: diff --git a/.scripts/commentLinesForSetup.sh b/.scripts/commentLinesForSetup.sh deleted file mode 100644 index c0dfd40e9f..0000000000 --- a/.scripts/commentLinesForSetup.sh +++ /dev/null @@ -1,7 +0,0 @@ -#!/bin/sh - -# It Comments out the Line Query-Service & Frontend Section of deploy/docker/clickhouse-setup/docker-compose.yaml -# Update the Line Numbers when deploy/docker/clickhouse-setup/docker-compose.yaml chnages. -# Docs Ref.: https://github.com/SigNoz/signoz/blob/main/CONTRIBUTING.md#contribute-to-frontend-with-docker-installation-of-signoz - -sed -i 38,62's/.*/# &/' .././deploy/docker/clickhouse-setup/docker-compose.yaml diff --git a/Makefile b/Makefile index 5f4a3c1ac2..c110ebdaf2 100644 --- a/Makefile +++ b/Makefile @@ -178,6 +178,15 @@ clear-swarm-ch: @docker run --rm -v "$(PWD)/$(SWARM_DIRECTORY)/data:/pwd" busybox \ sh -c "cd /pwd && rm -rf clickhouse*/* zookeeper-*/*" +check-no-ee-references: + @echo "Checking for 'ee' package references in 'pkg' directory..." + @if grep -R --include="*.go" '.*/ee/.*' pkg/; then \ + echo "Error: Found references to 'ee' packages in 'pkg' directory"; \ + exit 1; \ + else \ + echo "No references to 'ee' packages found in 'pkg' directory"; \ + fi + test: go test ./pkg/query-service/app/metrics/... go test ./pkg/query-service/cache/... diff --git a/ee/query-service/constants/constants.go b/ee/query-service/constants/constants.go index 51d22e5b63..c1baa6320b 100644 --- a/ee/query-service/constants/constants.go +++ b/ee/query-service/constants/constants.go @@ -11,8 +11,6 @@ const ( var LicenseSignozIo = "https://license.signoz.io/api/v1" var LicenseAPIKey = GetOrDefaultEnv("SIGNOZ_LICENSE_API_KEY", "") var SaasSegmentKey = GetOrDefaultEnv("SIGNOZ_SAAS_SEGMENT_KEY", "") -var SpanRenderLimitStr = GetOrDefaultEnv("SPAN_RENDER_LIMIT", "2500") -var MaxSpansInTraceStr = GetOrDefaultEnv("MAX_SPANS_IN_TRACE", "250000") var FetchFeatures = GetOrDefaultEnv("FETCH_FEATURES", "false") var ZeusFeaturesURL = GetOrDefaultEnv("ZEUS_FEATURES_URL", "ZeusFeaturesURL") diff --git a/pkg/query-service/app/parser.go b/pkg/query-service/app/parser.go index bbf97c7adf..9ae242c19f 100644 --- a/pkg/query-service/app/parser.go +++ b/pkg/query-service/app/parser.go @@ -18,7 +18,6 @@ import ( promModel "github.com/prometheus/common/model" "go.uber.org/multierr" - "go.signoz.io/signoz/ee/query-service/constants" "go.signoz.io/signoz/pkg/query-service/app/metrics" "go.signoz.io/signoz/pkg/query-service/app/queryBuilder" "go.signoz.io/signoz/pkg/query-service/auth" @@ -255,7 +254,7 @@ func ParseSearchTracesParams(r *http.Request) (*model.SearchTracesParams, error) levelDownStr = "0" } if SpanRenderLimitStr == "" || SpanRenderLimitStr == "null" { - SpanRenderLimitStr = constants.SpanRenderLimitStr + SpanRenderLimitStr = baseconstants.SpanRenderLimitStr } levelUpInt, err := strconv.Atoi(levelUpStr) @@ -270,7 +269,7 @@ func ParseSearchTracesParams(r *http.Request) (*model.SearchTracesParams, error) if err != nil { return nil, err } - MaxSpansInTraceInt, err := strconv.Atoi(constants.MaxSpansInTraceStr) + MaxSpansInTraceInt, err := strconv.Atoi(baseconstants.MaxSpansInTraceStr) if err != nil { return nil, err } diff --git a/pkg/query-service/app/preferences/model.go b/pkg/query-service/app/preferences/model.go index 82b8e9c9f6..fce34653fb 100644 --- a/pkg/query-service/app/preferences/model.go +++ b/pkg/query-service/app/preferences/model.go @@ -7,7 +7,7 @@ import ( "strings" "github.com/jmoiron/sqlx" - "go.signoz.io/signoz/ee/query-service/model" + "go.signoz.io/signoz/pkg/query-service/model" ) type Range struct { diff --git a/pkg/query-service/constants/constants.go b/pkg/query-service/constants/constants.go index 8c8a038f2f..02211008c1 100644 --- a/pkg/query-service/constants/constants.go +++ b/pkg/query-service/constants/constants.go @@ -421,3 +421,6 @@ const DefaultFilterSuggestionsAttributesLimit = 50 const MaxFilterSuggestionsAttributesLimit = 100 const DefaultFilterSuggestionsExamplesLimit = 2 const MaxFilterSuggestionsExamplesLimit = 10 + +var SpanRenderLimitStr = GetOrDefaultEnv("SPAN_RENDER_LIMIT", "2500") +var MaxSpansInTraceStr = GetOrDefaultEnv("MAX_SPANS_IN_TRACE", "250000")