From 74e7a83172fd04d8d5924b1c61f227d43ac481c6 Mon Sep 17 00:00:00 2001 From: amlannandy Date: Sat, 31 May 2025 14:00:48 +0700 Subject: [PATCH] chore: address comments --- frontend/src/container/MetricsExplorer/Summary/Summary.tsx | 5 +++-- frontend/src/container/MetricsExplorer/events.ts | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/frontend/src/container/MetricsExplorer/Summary/Summary.tsx b/frontend/src/container/MetricsExplorer/Summary/Summary.tsx index 4251c698ce..46e65aef54 100644 --- a/frontend/src/container/MetricsExplorer/Summary/Summary.tsx +++ b/frontend/src/container/MetricsExplorer/Summary/Summary.tsx @@ -46,7 +46,7 @@ function Summary(): JSX.Element { const { pageSize, setPageSize } = usePageSize('metricsExplorer'); const [currentPage, setCurrentPage] = useState(1); const [orderBy, setOrderBy] = useState(DEFAULT_ORDER_BY); - const [heatmapView, sexHeatmapView] = useState( + const [heatmapView, setHeatmapView] = useState( TreemapViewType.TIMESERIES, ); @@ -295,8 +295,9 @@ function Summary(): JSX.Element { }; const handleSetHeatmapView = (view: TreemapViewType): void => { - sexHeatmapView(view); + setHeatmapView(view); logEvent(MetricsExplorerEvents.TreemapViewChanged, { + [MetricsExplorerEventKeys.Tab]: 'summary', [MetricsExplorerEventKeys.ViewType]: view, }); }; diff --git a/frontend/src/container/MetricsExplorer/events.ts b/frontend/src/container/MetricsExplorer/events.ts index e489182b81..014f533cfd 100644 --- a/frontend/src/container/MetricsExplorer/events.ts +++ b/frontend/src/container/MetricsExplorer/events.ts @@ -12,7 +12,7 @@ export enum MetricsExplorerEvents { PageSizeChanged = 'Metrics Explorer: Page size changed', OrderByApplied = 'Metrics Explorer: Order by applied', MetricMetadataUpdated = 'Metrics Explorer: Metric metadata updated', - OpenInExplorerClicked = 'Metric Explorer: Open in explorer clicked', + OpenInExplorerClicked = 'Metrics Explorer: Open in explorer clicked', InspectViewChanged = 'Metrics Explorer: Inspect view changed', InspectQueryChanged = 'Metrics Explorer: Inspect query changed', InspectPointClicked = 'Metrics Explorer: Inspect point clicked',