From 2fe9e53766436ce87b77152f1de61d514ab3b0a0 Mon Sep 17 00:00:00 2001 From: dhawal1248 Date: Tue, 12 Sep 2023 16:34:28 +0530 Subject: [PATCH 1/2] chore: prefer delta temporality by default --- deploy/docker-swarm/clickhouse-setup/docker-compose.yaml | 6 +++++- deploy/docker/clickhouse-setup/docker-compose-local.yaml | 6 +++++- deploy/docker/clickhouse-setup/docker-compose.yaml | 6 +++++- pkg/query-service/README.md | 2 +- pkg/query-service/tests/test-deploy/docker-compose.yaml | 6 +++++- 5 files changed, 21 insertions(+), 5 deletions(-) diff --git a/deploy/docker-swarm/clickhouse-setup/docker-compose.yaml b/deploy/docker-swarm/clickhouse-setup/docker-compose.yaml index cf39bf49c4..c55013abca 100644 --- a/deploy/docker-swarm/clickhouse-setup/docker-compose.yaml +++ b/deploy/docker-swarm/clickhouse-setup/docker-compose.yaml @@ -145,7 +145,11 @@ services: query-service: image: signoz/query-service:0.28.0 - command: [ "-config=/root/config/prometheus.yml" ] + command: + [ + "-config=/root/config/prometheus.yml", + "--prefer-delta=true" + ] # ports: # - "6060:6060" # pprof port # - "8080:8080" # query-service port diff --git a/deploy/docker/clickhouse-setup/docker-compose-local.yaml b/deploy/docker/clickhouse-setup/docker-compose-local.yaml index cce46073f3..3ac2d82d62 100644 --- a/deploy/docker/clickhouse-setup/docker-compose-local.yaml +++ b/deploy/docker/clickhouse-setup/docker-compose-local.yaml @@ -22,7 +22,11 @@ services: - ./prometheus.yml:/root/config/prometheus.yml - ../dashboards:/root/config/dashboards - ./data/signoz/:/var/lib/signoz/ - command: [ "-config=/root/config/prometheus.yml" ] + command: + [ + "-config=/root/config/prometheus.yml", + "--prefer-delta=true" + ] ports: - "6060:6060" - "8080:8080" diff --git a/deploy/docker/clickhouse-setup/docker-compose.yaml b/deploy/docker/clickhouse-setup/docker-compose.yaml index 0f96583036..b652aa748d 100644 --- a/deploy/docker/clickhouse-setup/docker-compose.yaml +++ b/deploy/docker/clickhouse-setup/docker-compose.yaml @@ -164,7 +164,11 @@ services: query-service: image: signoz/query-service:${DOCKER_TAG:-0.28.0} container_name: signoz-query-service - command: [ "-config=/root/config/prometheus.yml" ] + command: + [ + "-config=/root/config/prometheus.yml", + "--prefer-delta=true" + ] # ports: # - "6060:6060" # pprof port # - "8080:8080" # query-service port diff --git a/pkg/query-service/README.md b/pkg/query-service/README.md index ed0a1b887f..d792b47d55 100644 --- a/pkg/query-service/README.md +++ b/pkg/query-service/README.md @@ -55,7 +55,7 @@ If you are on arm64 processors (Apple M1 Macs) run sudo make run-arm ```console cd pkg/query-service go build -o build/query-service main.go -ClickHouseUrl=tcp://localhost:9001 STORAGE=clickhouse build/query-service +ClickHouseUrl=tcp://localhost:9001 STORAGE=clickhouse --prefer-delta=true build/query-service ``` # Frontend Configuration for local query-service. diff --git a/pkg/query-service/tests/test-deploy/docker-compose.yaml b/pkg/query-service/tests/test-deploy/docker-compose.yaml index ee1b98adf8..15fcec80c3 100644 --- a/pkg/query-service/tests/test-deploy/docker-compose.yaml +++ b/pkg/query-service/tests/test-deploy/docker-compose.yaml @@ -153,7 +153,11 @@ services: query-service: image: signoz/query-service:latest container_name: signoz-query-service - command: [ "-config=/root/config/prometheus.yml" ] + command: + [ + "-config=/root/config/prometheus.yml", + "--prefer-delta=true" + ] # ports: # - "6060:6060" # pprof port # - "8080:8080" # query-service port From 7ae0326f61d526b470af2598250ddecfbf4b7e2d Mon Sep 17 00:00:00 2001 From: Dhawal Sanghvi <43755122+dhawal1248@users.noreply.github.com> Date: Tue, 12 Sep 2023 19:46:23 +0530 Subject: [PATCH 2/2] Update pkg/query-service/README.md Co-authored-by: Prashant Shahi --- pkg/query-service/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/query-service/README.md b/pkg/query-service/README.md index d792b47d55..fc4064f9e7 100644 --- a/pkg/query-service/README.md +++ b/pkg/query-service/README.md @@ -55,7 +55,7 @@ If you are on arm64 processors (Apple M1 Macs) run sudo make run-arm ```console cd pkg/query-service go build -o build/query-service main.go -ClickHouseUrl=tcp://localhost:9001 STORAGE=clickhouse --prefer-delta=true build/query-service +ClickHouseUrl=tcp://localhost:9001 STORAGE=clickhouse build/query-service --prefer-delta=true ``` # Frontend Configuration for local query-service.