fix: AWS integration bugfixes (#7886)

* fix(AccountSettingsModal): add region deselect functionality to region selector

* fix(AWS integration): redirect help button to aws integration documentation

* style(Header): update button color on hover for improved visibility
This commit is contained in:
Shaheer Kochai 2025-05-20 08:18:11 +04:30 committed by GitHub
parent 10ba0e6b4f
commit 88239cec4d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 33 additions and 6 deletions

View File

@ -33,13 +33,16 @@
border: 1px solid var(--bg-slate-400); border: 1px solid var(--bg-slate-400);
background: var(--bg-ink-300); background: var(--bg-ink-300);
border-radius: 2px; border-radius: 2px;
color: var(--bg-vanilla-400);
font-size: 12px; font-size: 12px;
line-height: 10px; /* 83.333% */ line-height: 10px;
letter-spacing: 0.12px; letter-spacing: 0.12px;
width: 113px; width: 113px;
height: 32px; height: 32px;
cursor: pointer; cursor: pointer;
&,
&:hover {
color: var(--bg-vanilla-400);
}
} }
} }

View File

@ -33,10 +33,15 @@ function Header(): JSX.Element {
/> />
</div> </div>
<div className="cloud-header__actions"> <div className="cloud-header__actions">
<button className="cloud-header__help" type="button"> <a
href="https://signoz.io/blog/native-aws-integrations-with-autodiscovery/"
target="_blank"
rel="noopener noreferrer"
className="cloud-header__help"
>
<LifeBuoy size={12} /> <LifeBuoy size={12} />
Get Help Get Help
</button> </a>
</div> </div>
</div> </div>
); );

View File

@ -58,6 +58,23 @@ function AccountSettingsModal({
}); });
}; };
const handleRegionDeselect = useCallback(
(item: string): void => {
if (selectedRegions.includes(item)) {
setSelectedRegions(selectedRegions.filter((region) => region !== item));
if (includeAllRegions) {
setIncludeAllRegions(false);
}
}
},
[
selectedRegions,
includeAllRegions,
setSelectedRegions,
setIncludeAllRegions,
],
);
const renderRegionSelector = useCallback(() => { const renderRegionSelector = useCallback(() => {
if (isRegionSelectOpen) { if (isRegionSelectOpen) {
return ( return (
@ -93,17 +110,19 @@ function AccountSettingsModal({
maxTagCount={3} maxTagCount={3}
value={getRegionPreviewText(selectedRegions)} value={getRegionPreviewText(selectedRegions)}
open={false} open={false}
onDeselect={handleRegionDeselect}
/> />
</> </>
); );
}, [ }, [
isRegionSelectOpen, isRegionSelectOpen,
selectedRegions,
includeAllRegions, includeAllRegions,
handleIncludeAllRegionsChange, handleIncludeAllRegionsChange,
setIsRegionSelectOpen, selectedRegions,
handleRegionDeselect,
setSelectedRegions, setSelectedRegions,
setIncludeAllRegions, setIncludeAllRegions,
setIsRegionSelectOpen,
]); ]);
const renderAccountDetails = useCallback( const renderAccountDetails = useCallback(