From 895c721b37f09371bb3f3d828a23c7713146295d Mon Sep 17 00:00:00 2001
From: Yash Joshi <jyash97@gmail.com>
Date: Tue, 27 Dec 2022 23:13:13 +0530
Subject: [PATCH] fix(version): use link instead of click handler (#1931)

Co-authored-by: Palash Gupta <palashgdev@gmail.com>
---
 frontend/src/container/Version/index.tsx | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/frontend/src/container/Version/index.tsx b/frontend/src/container/Version/index.tsx
index e36a0c6d18..cad08351e3 100644
--- a/frontend/src/container/Version/index.tsx
+++ b/frontend/src/container/Version/index.tsx
@@ -1,6 +1,6 @@
 import { WarningFilled } from '@ant-design/icons';
 import { Button, Card, Form, Space, Typography } from 'antd';
-import React, { useCallback } from 'react';
+import React from 'react';
 import { useTranslation } from 'react-i18next';
 import { useSelector } from 'react-redux';
 import { AppState } from 'store/reducers';
@@ -14,10 +14,6 @@ function Version(): JSX.Element {
 	const [form] = Form.useForm();
 	const { t } = useTranslation();
 
-	const onClickUpgradeHandler = useCallback((link: string) => {
-		window.open(link, '_blank');
-	}, []);
-
 	const {
 		currentVersion,
 		latestVersion,
@@ -60,9 +56,8 @@ function Version(): JSX.Element {
 						placeholder={t('latest_version')}
 					/>
 					<Button
-						onClick={(): void =>
-							onClickUpgradeHandler('https://github.com/SigNoz/signoz/releases')
-						}
+						href="https://github.com/SigNoz/signoz/releases"
+						target="_blank"
 						type="link"
 					>
 						{t('release_notes')}
@@ -94,11 +89,8 @@ function Version(): JSX.Element {
 
 			{!isError && !isLatestVersion && (
 				<Button
-					onClick={(): void =>
-						onClickUpgradeHandler(
-							'https://signoz.io/docs/operate/docker-standalone/#upgrade',
-						)
-					}
+					href="https://signoz.io/docs/operate/docker-standalone/#upgrade"
+					target="_blank"
 				>
 					{t('read_how_to_upgrade')}
 				</Button>