From 921fca5e6776c9babd4d34ba0516ebf7fa92a5dd Mon Sep 17 00:00:00 2001 From: Srikanth Chekuri Date: Thu, 7 Sep 2023 15:20:14 +0530 Subject: [PATCH] fix: do not add redundant [] for array (#3484) --- pkg/query-service/app/clickhouseReader/reader.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/query-service/app/clickhouseReader/reader.go b/pkg/query-service/app/clickhouseReader/reader.go index 8f3d4cf424..ac011720aa 100644 --- a/pkg/query-service/app/clickhouseReader/reader.go +++ b/pkg/query-service/app/clickhouseReader/reader.go @@ -798,14 +798,14 @@ func (r *ClickHouseReader) GetServices(ctx context.Context, queryParams *model.G avg(durationNano) as avgDuration, count(*) as numCalls FROM %s.%s - WHERE serviceName = @serviceName AND name In [@names] AND timestamp>= @start AND timestamp<= @end`, + WHERE serviceName = @serviceName AND name In @names AND timestamp>= @start AND timestamp<= @end`, r.TraceDB, r.indexTable, ) errorQuery := fmt.Sprintf( `SELECT count(*) as numErrors FROM %s.%s - WHERE serviceName = @serviceName AND name In [@names] AND timestamp>= @start AND timestamp<= @end AND statusCode=2`, + WHERE serviceName = @serviceName AND name In @names AND timestamp>= @start AND timestamp<= @end AND statusCode=2`, r.TraceDB, r.indexTable, ) @@ -893,7 +893,7 @@ func (r *ClickHouseReader) GetServiceOverview(ctx context.Context, queryParams * quantile(0.50)(durationNano) as p50, count(*) as numCalls FROM %s.%s - WHERE serviceName = @serviceName AND name In [@names] AND timestamp>= @start AND timestamp<= @end`, + WHERE serviceName = @serviceName AND name In @names AND timestamp>= @start AND timestamp<= @end`, r.TraceDB, r.indexTable, ) args := []interface{}{} @@ -924,7 +924,7 @@ func (r *ClickHouseReader) GetServiceOverview(ctx context.Context, queryParams * toStartOfInterval(timestamp, INTERVAL @interval minute) as time, count(*) as numErrors FROM %s.%s - WHERE serviceName = @serviceName AND name In [@names] AND timestamp>= @start AND timestamp<= @end AND statusCode=2`, + WHERE serviceName = @serviceName AND name In @names AND timestamp>= @start AND timestamp<= @end AND statusCode=2`, r.TraceDB, r.indexTable, ) args = []interface{}{}