GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-05 15:50:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #845 from pranshuchittora/pranshuchittora/fix/trace-detail/events-error-handling

Browse Source 
fix(FE): trace detail events error handling
This commit is contained in:
Pranshu Chittora 2022-03-16 16:44:29 +05:30 committed by GitHub
commit 95d3a27769
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/src/container/Timeline/index.tsx
View File

@ -32,7 +32,7 @@ const Timeline = ({
});
let intervalUnit = INTERVAL_UNITS[0];
for (const idx in INTERVAL_UNITS) {
for (let idx = 0; idx < INTERVAL_UNITS.length; idx++) {
const standard_interval = INTERVAL_UNITS[idx];
if (baseSpread * standard_interval.multiplier < 1) {
if (idx > 1) intervalUnit = INTERVAL_UNITS[idx - 1];
@ -40,7 +40,7 @@ const Timeline = ({
}
}
setIntervalUnit(intervalUnit);
intervalUnit = intervalUnit || INTERVAL_UNITS[0];
setIntervals(
getIntervals({
baseInterval,
@ -49,7 +49,8 @@ const Timeline = ({
intervalUnit,
}),
);
}, []);
setIntervalUnit(intervalUnit);
}, [traceMetaData, globalTraceMetadata, setIntervalUnit]);
return (
<StyledDiv ref={ref} styledclass={[styles.timelineContainer]}>

1
frontend/src/container/Timeline/utils.ts
View File

@ -70,7 +70,6 @@ export const getIntervals = ({
tempBaseSpread -= intervalSpreadNormalized;
}
elapsedIntervals = interval_time;
const interval: Interval = {
label: `${toFixed(
resolveTimeFromInterval(interval_time + baseInterval, intervalUnit),

8
frontend/src/container/TraceDetail/SelectedSpanDetails/ErrorTag.tsx
View File

@ -1,6 +1,7 @@
import { Collapse, Modal } from 'antd';
import { StyledButton } from 'components/Styled';
import useThemeMode from 'hooks/useThemeMode';
import { keys, map } from 'lodash-es';
import React, { useState } from 'react';
import { ITraceTree } from 'types/api/trace/getTraceItem';
@ -24,9 +25,8 @@ const ErrorTag = ({ event }: ErrorTagProps): JSX.Element => {
return (
<>
{event?.map(({ attributeMap, name }) => {
const attributes = Object.keys(attributeMap);
{map(event, ({ attributeMap, name }) => {
const attributes = keys(attributeMap);
return (
<Collapse
key={`${name}${JSON.stringify(attributeMap)}`}
@ -38,7 +38,7 @@ const ErrorTag = ({ event }: ErrorTagProps): JSX.Element => {
header={name || attributeMap?.event}
key={name || attributeMap.event}
>
{attributes.map((event) => {
{map(attributes, (event) => {
const value = attributeMap[event];
const isEllipsed = value.length > 24;