GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-01 04:52:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: i18n support for settings page

Browse Source
This commit is contained in:
Pranshu Chittora 2022-04-05 15:44:01 +05:30
parent 170609a81f
commit 95f8dfb4bc
No known key found for this signature in database
GPG Key ID: 3A9E57A016CC0626
2 changed files with 29 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
frontend/public/locales/en/translation.json
View File

@ -1,3 +1,14 @@
{
"monitor_signup": "Monitor your applications. Find what is causing issues."
"monitor_signup": "Monitor your applications. Find what is causing issues.",
"settings": {
"total_retention_period": "Total Retention Period",
"move_to_s3": "Move to S3\n(should be lower than total retention period)",
"retention_success_message": "Congrats. The retention periods for {{name}} has been updated successfully.",
"retention_error_message": "There was an issue in changing the retention period for {{name}}. Please try again or reach out to support@signoz.io",
"retention_failed_message": "There was an issue in changing the retention period. Please try again or reach out to support@signoz.io",
"retention_comparison_error": "Total retention period for {{name}} can’t be lower than period after which data is moved to s3",
"retention_null_value_error": "Retention Period for {{name}} is not set yet. Please set by choosing below",
"retention_confirmation": "Are you sure you want to change the retention period?",
"retention_confirmation_description": "This will change the amount of storage needed for saving metrics & traces."
}
}

34
frontend/src/container/GeneralSettings/index.tsx
View File

@ -7,6 +7,7 @@ import TextToolTip from 'components/TextToolTip';
import useFetch from 'hooks/useFetch';
import { find } from 'lodash-es';
import React, { useCallback, useEffect, useMemo, useState } from 'react';
import { useTranslation } from 'react-i18next';
import { IDiskType } from 'types/api/disks/getDisks';
import { PayloadProps } from 'types/api/settings/getRetention';
@ -19,8 +20,8 @@ import {
} from './styles';
function GeneralSettings(): JSX.Element {
const { t } = useTranslation();
const [notifications, Element] = notification.useNotification();
const [modal, setModal] = useState<boolean>(false);
const [postApiLoading, setPostApiLoading] = useState<boolean>(false);
@ -82,12 +83,12 @@ function GeneralSettings(): JSX.Element {
name: 'Metrics',
retentionFields: [
{
name: 'Total Retention Period',
name: t('settings.total_retention_period'),
value: metricsTotalRetentionPeriod,
setValue: setMetricsTotalRetentionPeriod,
},
{
name: `Move to S3\n(should be lower than total retention period)`,
name: t('settings.move_to_s3'),
value: metricsS3RetentionPeriod,
setValue: setMetricsS3RetentionPeriod,
hide: !s3Enabled,
@ -98,12 +99,12 @@ function GeneralSettings(): JSX.Element {
name: 'Traces',
retentionFields: [
{
name: 'Total Retention Period',
name: t('settings.total_retention_period'),
value: tracesTotalRetentionPeriod,
setValue: setTracesTotalRetentionPeriod,
},
{
name: `Move to S3\n(should be lower than total retention period)`,
name: t('settings.move_to_s3'),
value: tracesS3RetentionPeriod,
setValue: setTracesS3RetentionPeriod,
hide: !s3Enabled,
@ -165,12 +166,13 @@ function GeneralSettings(): JSX.Element {
notifications.success({
message: 'Success!',
placement: 'topRight',
description: `Congrats. The retention periods for ${name} has been updated successfully.`,
description: t('settings.retention_success_message', { name }),
});
} else {
notifications.error({
message: 'Error',
description: `There was an issue in changing the retention period for ${name}. Please try again or reach out to support@signoz.io`,
description: t('settings.retention_error_message', { name }),
placement: 'topRight',
});
}
@ -180,8 +182,7 @@ function GeneralSettings(): JSX.Element {
} catch (error) {
notifications.error({
message: 'Error',
description:
'There was an issue in changing the retention period. Please try again or reach out to support@signoz.io',
description: t('settings.retention_failed_message'),
placement: 'topRight',
});
}
@ -191,10 +192,10 @@ function GeneralSettings(): JSX.Element {
const [isDisabled, errorText] = useMemo(() => {
// Various methods to return dynamic error message text.
const messages = {
compareError: (value: string | number): string =>
`Total retention period for ${value} can’t be lower than period after which data is moved to s3`,
nullValueError: (value: string | number): string =>
`Retention Peroid for ${value} is not set yet. Please set by choosing below`,
compareError: (name: string | number): string =>
t('settings.retention_comparison_error', { name }),
nullValueError: (name: string | number): string =>
t('settings.retention_null_value_error', { name }),
};
// Defaults to button not disabled and empty error message text.
@ -232,6 +233,7 @@ function GeneralSettings(): JSX.Element {
metricsS3RetentionPeriod,
metricsTotalRetentionPeriod,
s3Enabled,
t,
tracesS3RetentionPeriod,
tracesTotalRetentionPeriod,
]);
@ -271,7 +273,7 @@ function GeneralSettings(): JSX.Element {
<Row justify="space-around">{renderConfig}</Row>
<Modal
title="Are you sure you want to change the retention period?"
title={t('settings.retention_confirmation')}
focusTriggerAfterClose
forceRender
destroyOnClose
@ -282,9 +284,7 @@ function GeneralSettings(): JSX.Element {
visible={modal}
confirmLoading={postApiLoading}
>
<Typography>
This will change the amount of storage needed for saving metrics & traces.
</Typography>
<Typography>{t('settings.retention_confirmation_description')}</Typography>
</Modal>
<ButtonContainer>