GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-14 16:25:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: sort tags and events in trace detail (#4962)

Browse Source
This commit is contained in:
Vishal Sharma 2024-05-05 09:03:31 +05:30 committed by GitHub
parent 08b1a87cb5
commit 967aa16f21
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
frontend/src/container/TraceDetail/SelectedSpanDetails/Events/index.tsx
View File

@ -13,11 +13,18 @@ function Events({
return <Typography>No events data in selected span</Typography>; return <Typography>No events data in selected span</Typography>;
} }
const sortedTraceEvents = events.sort((a, b) => {
// Handle undefined names by treating them as empty strings
const nameA = a.name || '';
const nameB = b.name || '';
return nameA.localeCompare(nameB);
});
return ( return (
<ErrorTag <ErrorTag
onToggleHandler={onToggleHandler} onToggleHandler={onToggleHandler}
setText={setText} setText={setText}
event={events} event={sortedTraceEvents}
firstSpanStartTime={firstSpanStartTime} firstSpanStartTime={firstSpanStartTime}
/> />
); );

5
frontend/src/container/TraceDetail/SelectedSpanDetails/Tags/index.tsx
View File

@ -41,8 +41,9 @@ function Tags({
setSearchText(value); setSearchText(value);
}; };
const filteredTags = tags.filter((tag) => tag.key.includes(searchText)); const filteredTags = tags
.filter((tag) => tag.key.includes(searchText))
.sort((a, b) => a.key.localeCompare(b.key));
if (tags.length === 0) { if (tags.length === 0) {
return <Typography>No tags in selected span</Typography>; return <Typography>No tags in selected span</Typography>;
} }